From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753691AbbGPD4M (ORCPT ); Wed, 15 Jul 2015 23:56:12 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:60126 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752679AbbGPD4J (ORCPT ); Wed, 15 Jul 2015 23:56:09 -0400 X-AuditID: cbfee691-f79ca6d00000456a-2a-55a72b575bf5 From: Maninder Singh To: kvalo@qca.qualcomm.com, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: pankaj.m@samsung.com, Maninder Singh Subject: [PATCH 1/1] ath10k: fixing wrong initialization of struct channel Date: Thu, 16 Jul 2015 09:25:33 +0530 Message-id: <1437018933-25832-1-git-send-email-maninder1.s@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDLMWRmVeSWpSXmKPExsWyRsSkVjdce3moQcsjEYtHl44xW1z7P4fV 4vKuOWwWb1bcYbc4PL+NxeLYAjGLe2+2Mjmwe2xeUu9x6MMRVo++LasYPT5vkgtgieKySUnN ySxLLdK3S+DKePdmI1PBUvaKrqv3WBoYJ7J1MXJySAiYSDyad4cZwhaTuHBvPVCci0NIYCmj xMPp51hhij7cP8wCkVjEKDGjbQsrhPOTUeLR5PssIFVsAnoSq3btAasSEZjAKHHy0Qz2LkYO DmYBJ4npX/VAaoQFvCQe9jeArWMRUJU40bMDbAOvgLvEqsWbGUHKJQQUJOZMsgEZIyHwnU1i 9tT/LBD1AhLfJh9igaiRldh0AOpqSYmDK26wTGAUXMDIsIpRNLUguaA4Kb3IVK84Mbe4NC9d Lzk/dxMjMFBP/3s2cQfj/QPWhxgFOBiVeHg3/FgWKsSaWFZcmXuI0RRow0RmKdHkfGA85JXE GxqbGVmYmpgaG5lbmimJ8+pI/wwWEkhPLEnNTk0tSC2KLyrNSS0+xMjEwSnVwGgf73n6aZC5 xb/pgXyPFQ78s9T+Y3x03opX2sJGQdaJEX32bDaO//o2J6lG5gfe+ZTrYrZKqrP6uegkplsO TdzpLmybXeU+1+sIK3icOWX51U2jUF0+YF3991qXxs9cFvyhgU6RdzLWnb+q/k+seNcx+V7N 1cyNG5ac3MN08oiGCL/G50AhJZbijERDLeai4kQAPGvyg08CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjkeLIzCtJLcpLzFFi42I5/e+xgG649vJQg+sXeS0eXTrGbHHt/xxW i8u75rBZvFlxh93i8Pw2FotjC8Qs7r3ZyuTA7rF5Sb3HoQ9HWD36tqxi9Pi8SS6AJaqB0SYj NTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH6AAlhbLEnFKg UEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGENY8a7NxuZCpayV3RdvcfSwDiRrYuRk0NC wETiw/3DLBC2mMSFe+uB4lwcQgKLGCVmtG1hhXB+Mko8mnwfrIpNQE9i1a49LCAJEYEJjBIn H81g72Lk4GAWcJKY/lUPpEZYwEviYX8DM4jNIqAqcaJnByuIzSvgLrFq8WZGkHIJAQWJOZNs JjByL2BkWMUomlqQXFCclJ5rpFecmFtcmpeul5yfu4kRHAfPpHcwrmqwOMQowMGoxMPL8XtZ qBBrYllxZe4hRgkOZiURXq+XQCHelMTKqtSi/Pii0pzU4kOMpkDLJzJLiSbnA2M0ryTe0NjE 3NTY1NLEwsTMUkmc92S+T6iQQHpiSWp2ampBahFMHxMHp1QDo9HR6Uu3/J1+bqpi68U/Z+XZ 9ENtGt9I1KzYxKH7d7ZgzX3hzQENfQLiT2f9PtL7R05td9sdv/V2O495c/Zy1jB7nNHxXvLP zO7/rC0qwX5xEx1cm+wSDNZuMpI+o86jahLxKCOR7yvzxV0/W55IsDj+0s6YHPgthuXkm28N F/Ury//Gs/BaKbEUZyQaajEXFScCAKaJfW2ZAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org chandef is initialized with NULL and on the very next line, we are using it to get channel, which is not correct. channel should be initialized after obtaining chandef. Signed-off-by: Maninder Singh --- drivers/net/wireless/ath/ath10k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 218b6af..3d196b5 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -836,7 +836,7 @@ static inline int ath10k_vdev_setup_sync(struct ath10k *ar) static int ath10k_monitor_vdev_start(struct ath10k *ar, int vdev_id) { struct cfg80211_chan_def *chandef = NULL; - struct ieee80211_channel *channel = chandef->chan; + struct ieee80211_channel *channel = NULL; struct wmi_vdev_start_request_arg arg = {}; int ret = 0; -- 1.7.9.5