From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755491AbbGPTMl (ORCPT ); Thu, 16 Jul 2015 15:12:41 -0400 Received: from smtprelay0001.hostedemail.com ([216.40.44.1]:41827 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751637AbbGPTMk (ORCPT ); Thu, 16 Jul 2015 15:12:40 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3867:3868:3870:3872:3874:4250:4321:5007:6261:10004:10400:10848:11026:11232:11658:11914:12043:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: beds82_8b6d016b82b11 X-Filterd-Recvd-Size: 1618 Message-ID: <1437073957.2495.32.camel@perches.com> Subject: Re: [PATCH] staging: rtl8188eu: Fix style errors and warnings From: Joe Perches To: Greg KH Cc: Guillaume Bienkowski , luca@lucaceresoli.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Thu, 16 Jul 2015 12:12:37 -0700 In-Reply-To: <20150716171134.GA13728@kroah.com> References: <1437032496-19275-1-git-send-email-guitreize@gmail.com> <20150716171134.GA13728@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-07-16 at 10:11 -0700, Greg KH wrote: > On Thu, Jul 16, 2015 at 09:41:36AM +0200, Guillaume Bienkowski wrote: > > Fix spaces before comma and indentation. > > That's two different things, so this should be two different patches > please. I think it'd be better to do all the whitespace changes in a single go: $ git ls-files drivers/staging/rtl8188eu | \ xargs ./scripts/checkpatch.pl -f --fix-inplace --types=spacing,space_before_tab,pointer_location,trailing_whitespace,bracket_space --strict and submit the git diff with "whitespace style changes" after verifying that objdiff shows no changes. 64 files changed, 1240 insertions(+), 1240 deletions(-) It's ~330KB patch though.