From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, jolsa@redhat.com,
namhyung@kernel.org, Ingo Molnar <mingo@redhat.com>,
Taeung Song <treeze.taeung@gmail.com>
Subject: [PATCH v4 0/5] perf tools: Add 'perf-config' command
Date: Fri, 17 Jul 2015 10:39:57 +0900 [thread overview]
Message-ID: <1437097202-1915-1-git-send-email-treeze.taeung@gmail.com> (raw)
Changes in v4:
- If some config value is default value, notice it is '(default)'as below.
# perf config colors.normal
colors.normal=lightgray, default (default)
- A config file path is only decided in perf_config().
And a perf-config command depend on perf_config() deciding a config file path.
So if the config file path is NULL because of some reason like no such file,
a perf-config command can't write to the file. So, I added new options
which are '--global' and '--system' to be enable to select
config file path to be used without perf_config().
Changes in v3:
- Add a config variable 'kmem.default' with a default value
into 'struct default_configset' which has default config variables and values.
- Add a option '--global' and '--local' to enable config file location to be selected
Changes in v2:
- Renaming variables a more suitable name
1. '--list-all' instead of '--all'
2. 'name' instead of 'subkey'
3. 'section, name, value' instead of 'given_section, subkey, value'
- Correct small infelicities or typing errors in a perf-config documention.
- Remove a part description of report.children
because it was duplicated in Documentation/callchain-overhead-calculation.txt
- Use a variable 'int actions' instead of struct params which has
'bool list_action' , 'bool get_action’ and etc. , to simplify a branching statement
for perf-config options.
- Declaration a global variable 'static struct default_configsets' has config variables
with default values instead of using a 'util/PERFCONFIG-DEFAULT' file
and remove functions merge() and perse_key() to get perf config default values.
- Add a function to normalize a value and check data type of it.
- Simplify parsing arguments as arguments is just divided by '=' and then
in front of '.' is a section, between '.' and '=' is a name, and behind '=' is a value.
- Print config variables 'struct default_configsets' haven't
- Make a command ’perf config' without a option work as with a option '—list'
instead of '--list-all’.
Taeung Song (5):
perf tools: Add 'perf-config' command
perf config: Add '--system' and '--global' options to be able to
select which config file to be used
perf config: Add functions which can get or set perf config variables
perf config: Add a option 'list-all' to perf-config
perf config: Add a option 'remove' to perf-config
tools/perf/Build | 1 +
tools/perf/Documentation/perf-config.txt | 407 ++++++++++++++++
tools/perf/Documentation/perfconfig.example | 73 ++-
tools/perf/builtin-config.c | 718 ++++++++++++++++++++++++++++
tools/perf/builtin.h | 1 +
tools/perf/command-list.txt | 1 +
tools/perf/perf.c | 1 +
tools/perf/util/cache.h | 19 +
tools/perf/util/config.c | 29 +-
9 files changed, 1236 insertions(+), 14 deletions(-)
create mode 100644 tools/perf/Documentation/perf-config.txt
create mode 100644 tools/perf/builtin-config.c
--
1.9.1
next reply other threads:[~2015-07-19 9:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 1:39 Taeung Song [this message]
2015-07-17 1:39 ` [PATCH v4 1/5] " Taeung Song
2015-07-17 1:39 ` [PATCH v4 2/5] perf config: Add '--system' and '--global' options to be able to select which config file to be used Taeung Song
2015-07-17 1:40 ` [PATCH v4 3/5] perf config: Add functions which can get or set perf config variables Taeung Song
2015-07-17 1:40 ` [PATCH v4 4/5] perf config: Add a option 'list-all' to perf-config Taeung Song
2015-07-17 1:40 ` [PATCH v4 5/5] perf config: Add a option 'remove' " Taeung Song
2015-07-19 13:39 ` [PATCH v4 0/5] perf tools: Add 'perf-config' command Namhyung Kim
2015-07-26 15:58 Taeung Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437097202-1915-1-git-send-email-treeze.taeung@gmail.com \
--to=treeze.taeung@gmail.com \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®