From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756735AbbGQGM3 (ORCPT ); Fri, 17 Jul 2015 02:12:29 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:34829 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751852AbbGQGM1 (ORCPT ); Fri, 17 Jul 2015 02:12:27 -0400 From: Sergey Senozhatsky X-Google-Original-From: Sergey Senozhatsky To: Andrew Morton Cc: Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky , Sergey Senozhatsky Subject: [PATCH] mm/rmap: disable preemption for trace_tlb_flush() Date: Fri, 17 Jul 2015 15:12:54 +0900 Message-Id: <1437113574-2047-1-git-send-email-sergey.senozhatsky@gmail.com> X-Mailer: git-send-email 2.4.6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tlb_flush contains TP_CONDITION(cpu_online(smp_processor_id())) which is better be executed with preemption disabled. Move trace_tlb_flush(TLB_REMOTE_SHOOTDOWN) in try_to_unmap_flush() under get_cpu(). Signed-off-by: Sergey Senozhatsky --- mm/rmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/rmap.c b/mm/rmap.c index 30812e9..74086cc 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -613,9 +613,9 @@ void try_to_unmap_flush(void) if (!tlb_ubc->flush_required) return; + cpu = get_cpu(); trace_tlb_flush(TLB_REMOTE_SHOOTDOWN, -1UL); - cpu = get_cpu(); if (cpumask_test_cpu(cpu, &tlb_ubc->cpumask)) percpu_flush_tlb_batch_pages(&tlb_ubc->cpumask); -- 2.4.6