From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753393AbbGWMMc (ORCPT ); Thu, 23 Jul 2015 08:12:32 -0400 Received: from mga03.intel.com ([134.134.136.65]:27680 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752504AbbGWMJm (ORCPT ); Thu, 23 Jul 2015 08:09:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,530,1432623600"; d="scan'208";a="611456704" From: Tomas Winkler To: Greg Kroah-Hartman Cc: arnd@arndb.de, Alexander Usyskin , linux-kernel@vger.kernel.org, Tomas Winkler Subject: [char-misc-next 05/15 V3] mei: bus: don't enable events implicitly in device enable Date: Thu, 23 Jul 2015 15:08:37 +0300 Message-Id: <1437653327-3308-6-git-send-email-tomas.winkler@intel.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1437653327-3308-1-git-send-email-tomas.winkler@intel.com> References: <1437653327-3308-1-git-send-email-tomas.winkler@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Do not enable events implicitly in mei_cl_enable_device, it should be done explicitly using mei_cl_register_event_cb so the events are enabled only when needed. The NFC drivers has been already using it that way so no need for further changes just remove the code from mei_cl_enable_device. Signed-off-by: Tomas Winkler --- V2: fix the commit message V3: rebase drivers/misc/mei/bus.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c index bec213b92550..257e200b5343 100644 --- a/drivers/misc/mei/bus.c +++ b/drivers/misc/mei/bus.c @@ -332,9 +332,6 @@ int mei_cl_enable_device(struct mei_cl_device *cldev) mutex_unlock(&bus->device_lock); - if (cldev->event_cb) - mei_cl_read_start(cldev->cl, 0, NULL); - return 0; } EXPORT_SYMBOL_GPL(mei_cl_enable_device); -- 2.4.3