From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753969AbbGXKcm (ORCPT ); Fri, 24 Jul 2015 06:32:42 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:38306 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751089AbbGXKcg (ORCPT ); Fri, 24 Jul 2015 06:32:36 -0400 From: David Herrmann To: linux-kernel@vger.kernel.org Cc: Greg KH , Daniel Mack , Djalal Harouni , Alban Browaeys , David Herrmann Subject: [PATCH] kdbus: fix wrong message size on 32bit Date: Fri, 24 Jul 2015 12:32:09 +0200 Message-Id: <1437733929-30378-1-git-send-email-dh.herrmann@gmail.com> X-Mailer: git-send-email 2.4.6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When broadcasting messages, each receiver might get a different message due to different metadata requirements. Therefore, the value of msg->size might be different for each receiver. To account for that, we use a temporary variable to store the real size and use it as source for the iovec-copy transaction instead of &msg->size. But we incorrectly used "size_t" for this variable. Hence, on 32bit, we end up missing 4 bytes of the message header as "size_t" might only be 32bit wide. Fix this and properly use "u64" for the message size that is copied to user-space. Reported-by: Alban Browaeys Signed-off-by: David Herrmann --- ipc/kdbus/message.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ipc/kdbus/message.c b/ipc/kdbus/message.c index 27a5021..432dba4 100644 --- a/ipc/kdbus/message.c +++ b/ipc/kdbus/message.c @@ -886,9 +886,9 @@ struct kdbus_pool_slice *kdbus_staging_emit(struct kdbus_staging *staging, { struct kdbus_item *item, *meta_items = NULL; struct kdbus_pool_slice *slice = NULL; - size_t off, size, msg_size, meta_size; + size_t off, size, meta_size; struct iovec *v; - u64 attach; + u64 attach, msg_size; int ret; /* -- 2.4.6