From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752563AbbGXLqV (ORCPT ); Fri, 24 Jul 2015 07:46:21 -0400 Received: from mga11.intel.com ([192.55.52.93]:64568 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752047AbbGXLqS (ORCPT ); Fri, 24 Jul 2015 07:46:18 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,538,1432623600"; d="scan'208";a="770449647" From: Alexander Shishkin To: Peter Zijlstra , Ingo Molnar Cc: linux-kernel@vger.kernel.org, adrian.hunter@intel.com, Arnaldo Carvalho de Melo , Vince Weaver , Stephane Eranian , Alexander Shishkin Subject: [PATCH RFC v1 0/4] perf: Introduce extended syscall error reporting Date: Fri, 24 Jul 2015 14:45:55 +0300 Message-Id: <1437738359-23920-1-git-send-email-alexander.shishkin@linux.intel.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter and Ingo and everybody, Here's my second stab at improving perf's error reporting by attaching arbitrary strings to the integer error codes. This is largely based off of the previous email thread [1]. This time around, I employed a linker trick to convert the structures containing extended error information into integers, which are then made to look just like normal error codes so that IS_ERR_VALUE() and friends would still work correctly on them. So no extra pointers in the struct perf_event or anywhere else; the extended error codes are passed around like normal error codes. They only need to be converted in syscalls' topmost return statements. This is done in 1/4. Then, 2/4 illustrates how error sites can be extended to include more information such as file names and line numbers [1]. The other two patches add perf_err() annotation to a few semi-randomly picked places in perf core (3/4) and x86 bits (4/4). [1] http://marc.info/?l=linux-kernel&m=141470811013082 [2] http://marc.info/?l=linux-kernel&m=141471816115946 Alexander Shishkin (4): perf: Introduce extended syscall error reporting perf: Add file name and line number to perf extended error reports perf: Annotate some of the error codes with perf_err() perf/x86: Annotate some of the error codes with perf_err() arch/x86/kernel/cpu/perf_event.c | 8 ++- arch/x86/kernel/cpu/perf_event_intel_lbr.c | 2 +- include/linux/perf_event.h | 87 +++++++++++++++++++++++ include/uapi/linux/perf_event.h | 8 ++- kernel/events/core.c | 108 +++++++++++++++++++++++++---- 5 files changed, 195 insertions(+), 18 deletions(-) -- 2.1.4