From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755016AbbGYHtu (ORCPT ); Sat, 25 Jul 2015 03:49:50 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:36722 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754877AbbGYHtt (ORCPT ); Sat, 25 Jul 2015 03:49:49 -0400 From: Sudip Mukherjee To: Greg KH Cc: linux-kernel@vger.kernel.org, Ying Huang , Sudip Mukherjee Subject: [PATCH] parport: Revert "parport: fix memory leak" Date: Sat, 25 Jul 2015 13:19:40 +0530 Message-Id: <1437810580-1747-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit 23c405912b88 ("parport: fix memory leak") par_dev->state was already being removed in parport_unregister_device(). Reported-by: Ying Huang Signed-off-by: Sudip Mukherjee --- But I am surprised at two points: 1) Why the error came while loading the gs_fpgaboot module? Maybe the double freeing has freed some memory which fpga was using. 2) Why the dmesg showed "panel: could not claim access to parport0. Aborting."? Because of 50566ac87065 ("parport: check exclusive access before register") the panel driver should not even register and it should have failed at parport_register_dev_model(). drivers/parport/share.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/parport/share.c b/drivers/parport/share.c index c02b5f2..5ce5ef2 100644 --- a/drivers/parport/share.c +++ b/drivers/parport/share.c @@ -816,7 +816,6 @@ static void free_pardevice(struct device *dev) struct pardevice *par_dev = to_pardevice(dev); kfree(par_dev->name); - kfree(par_dev->state); kfree(par_dev); } -- 1.9.1