From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754336AbbG0JWH (ORCPT ); Mon, 27 Jul 2015 05:22:07 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:38839 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753298AbbG0JWC (ORCPT ); Mon, 27 Jul 2015 05:22:02 -0400 X-AuditID: cbfee61a-f79a06d000005c6f-c0-55b5f838d9ad From: Robert Baldyga To: balbi@ti.com Cc: gregkh@linuxfoundation.org, Peter.Chen@freescale.com, johnyoun@synopsys.com, dahlmann.thomas@arcor.de, nicolas.ferre@atmel.com, cernekee@gmail.com, leoli@freescale.com, daniel@zonque.org, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, michal.simek@xilinx.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-geode@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, andrzej.p@samsung.com, m.szyprowski@samsung.com, stern@rowland.harvard.edu, petr.cvek@tul.cz, Robert Baldyga Subject: [PATCH v4 38/46] usb: gadget: epautoconf: remove pxa quirk from ep_matches() Date: Mon, 27 Jul 2015 11:16:48 +0200 Message-id: <1437988616-6962-39-git-send-email-r.baldyga@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1437988616-6962-1-git-send-email-r.baldyga@samsung.com> References: <1437988616-6962-1-git-send-email-r.baldyga@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNIsWRmVeSWpSXmKPExsVy+t9jAV3LH1tDDf60s1vMetnOYnHwfr3F 3gV3GS067x9mtmj6+4rFYs+ZX+wWzYvXs1lcWGdusfv0JUaLXw+ELDY9vsZq0X/uNIvF5V1z 2CxmL+lnsVi0rJXZ4vf3f6wWa4/cZbd49zLC4tvlZnaLY7P/MlnM75jKavHg8E6gTW+ELSb8 vsDmIOEx+clGJo8Fv7ayeNzbd5jFo3/dZ1aPf4f7mTx2zrrL7rF/7hp2j81L6j3Oz1jI6DH7 7g9Gj74tqxg9tuz/zOhx/MZ2Jo+ZK3vZPD5vkvPY+/k3S4BgFJdNSmpOZllqkb5dAlfGvZ5f LAUP+Suenv3P0sC4k6eLkZNDQsBE4uq1dYwQtpjEhXvr2boYuTiEBJYySrR9XMMKkhAS+Mko 8f5cFYjNJqAjseX7BLAGEQEBifUvLrGDNDAL/GCRODuvG8jh4BAWCJdYvFsTpIZFQFVicfd3 dhCbV8BVom3pAhaIZXISJ49NBpvPCRRfMm0rE0irkICLxJHrWhMYeRcwMqxilEgtSC4oTkrP NcxLLdcrTswtLs1L10vOz93ECI6yZ1I7GA/ucj/EKMDBqMTDe0Fla6gQa2JZcWXuIUYJDmYl Ed7HUUAh3pTEyqrUovz4otKc1OJDjNIcLErivLIbNocKCaQnlqRmp6YWpBbBZJk4OKUaGF2y 9Asdjkx9d/3x/Cq1Y/IqEg1ltXtFnzvr1aeHRLr843zAYlS0TPZz6BR5rXe/EiJM1wo37nrB 2PeitfFP7wuNxatafk1wXmoxObNo2UH9c9vW+Nh3ssYp+B1yPajCne8zwWL+svuhJ8uXK5mF May3OCTEfq0wRuK69+GrIavvqeXEVbxeq8RSnJFoqMVcVJwIAF3M65iuAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The same effect can be achieved by using capabilities flags, so now we can get rid of handling of hardware specific limitations in generic code. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/epautoconf.c | 5 ----- drivers/usb/gadget/udc/pxa25x_udc.c | 9 +++------ 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/usb/gadget/epautoconf.c b/drivers/usb/gadget/epautoconf.c index af4b10a..4f66e9d73 100644 --- a/drivers/usb/gadget/epautoconf.c +++ b/drivers/usb/gadget/epautoconf.c @@ -58,11 +58,6 @@ ep_matches ( */ if (!ep->caps.type_int && !ep->caps.type_bulk) return 0; - /* for now, avoid PXA "interrupt-in"; - * it's documented as never using DATA1. - */ - if (gadget_is_pxa(gadget) && ep->caps.type_int) - return 0; break; } diff --git a/drivers/usb/gadget/udc/pxa25x_udc.c b/drivers/usb/gadget/udc/pxa25x_udc.c index 1301e29..f53e526 100644 --- a/drivers/usb/gadget/udc/pxa25x_udc.c +++ b/drivers/usb/gadget/udc/pxa25x_udc.c @@ -1898,8 +1898,7 @@ static struct pxa25x_udc memory = { .name = "ep5in-int", .ops = &pxa25x_ep_ops, .maxpacket = INT_FIFO_SIZE, - .caps = USB_EP_CAPS(USB_EP_CAPS_TYPE_INT, - USB_EP_CAPS_DIR_IN), + .caps = USB_EP_CAPS(0, 0), }, .dev = &memory, .fifo_size = INT_FIFO_SIZE, @@ -1977,8 +1976,7 @@ static struct pxa25x_udc memory = { .name = "ep10in-int", .ops = &pxa25x_ep_ops, .maxpacket = INT_FIFO_SIZE, - .caps = USB_EP_CAPS(USB_EP_CAPS_TYPE_INT, - USB_EP_CAPS_DIR_IN), + .caps = USB_EP_CAPS(0, 0), }, .dev = &memory, .fifo_size = INT_FIFO_SIZE, @@ -2056,8 +2054,7 @@ static struct pxa25x_udc memory = { .name = "ep15in-int", .ops = &pxa25x_ep_ops, .maxpacket = INT_FIFO_SIZE, - .caps = USB_EP_CAPS(USB_EP_CAPS_TYPE_INT, - USB_EP_CAPS_DIR_IN), + .caps = USB_EP_CAPS(0, 0), }, .dev = &memory, .fifo_size = INT_FIFO_SIZE, -- 1.9.1