From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 08/11] staging: rtl8192e: Remove phy_RF8256_Config_ParaFile
Date: Tue, 28 Jul 2015 23:31:44 +0200 [thread overview]
Message-ID: <1438119107-26176-9-git-send-email-mateusz.kulikowski@gmail.com> (raw)
In-Reply-To: <1438119107-26176-1-git-send-email-mateusz.kulikowski@gmail.com>
Merge function into rtl92e_config_rf as having them
separated gives no benefit.
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
index 85f9341..194d64c 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
@@ -64,7 +64,7 @@ void rtl92e_set_bandwidth(struct net_device *dev,
}
}
-static bool phy_RF8256_Config_ParaFile(struct net_device *dev)
+bool rtl92e_config_rf(struct net_device *dev)
{
u32 u4RegValue = 0;
u8 eRFPath;
@@ -77,6 +77,8 @@ static bool phy_RF8256_Config_ParaFile(struct net_device *dev)
u8 ConstRetryTimes = 5, RetryTimes = 5;
u8 ret = 0;
+ priv->NumTotalRFPath = RTL819X_TOTAL_RF_PATH;
+
for (eRFPath = (enum rf90_radio_path)RF90_PATH_A;
eRFPath < priv->NumTotalRFPath; eRFPath++) {
if (!rtl92e_is_legal_rf_path(dev, eRFPath))
@@ -115,7 +117,7 @@ static bool phy_RF8256_Config_ParaFile(struct net_device *dev)
if (!rtStatus) {
netdev_err(dev, "%s(): Failed to check RF Path %d.\n",
__func__, eRFPath);
- goto phy_RF8256_Config_ParaFile_Fail;
+ goto fail;
}
RetryTimes = ConstRetryTimes;
@@ -203,7 +205,7 @@ static bool phy_RF8256_Config_ParaFile(struct net_device *dev)
netdev_err(dev,
"%s(): Failed to initialize RF Path %d.\n",
__func__, eRFPath);
- goto phy_RF8256_Config_ParaFile_Fail;
+ goto fail;
}
}
@@ -211,18 +213,10 @@ static bool phy_RF8256_Config_ParaFile(struct net_device *dev)
RT_TRACE(COMP_PHY, "PHY Initialization Success\n");
return true;
-phy_RF8256_Config_ParaFile_Fail:
+fail:
return false;
}
-bool rtl92e_config_rf(struct net_device *dev)
-{
- struct r8192_priv *priv = rtllib_priv(dev);
-
- priv->NumTotalRFPath = RTL819X_TOTAL_RF_PATH;
- return phy_RF8256_Config_ParaFile(dev);
-}
-
void rtl92e_set_cck_tx_power(struct net_device *dev, u8 powerlevel)
{
u32 TxAGC = 0;
--
1.8.4.1
next prev parent reply other threads:[~2015-07-28 21:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 21:31 [PATCH 00/11] staging: rtl8192e: More cleanups Mateusz Kulikowski
2015-07-28 21:31 ` [PATCH 01/11] staging: rtl8192e: Remove rtl8192_phy_updateInitGain Mateusz Kulikowski
2015-07-28 21:31 ` [PATCH 02/11] staging: rtl8192e: Remove ActUpdateChannelAccessSetting Mateusz Kulikowski
2015-07-28 21:31 ` [PATCH 03/11] staging: rtl8192e: Remove rtl8192_data_hard_stop Mateusz Kulikowski
2015-07-28 21:31 ` [PATCH 04/11] staging: rtl8192e: Remove rtl8192_data_hard_resume Mateusz Kulikowski
2015-07-28 21:31 ` [PATCH 05/11] staging: rtl8192e: MgntActSet_RF_State: remove ProtectOrNot parameter Mateusz Kulikowski
2015-07-28 21:31 ` [PATCH 06/11] staging: rtl8192e: Simplify rtl92e_is_halfn_supported_by_ap Mateusz Kulikowski
2015-07-28 21:31 ` [PATCH 07/11] staging: rtl8192e: Simplify rtl92e_set_bandwidth Mateusz Kulikowski
2015-07-28 21:31 ` Mateusz Kulikowski [this message]
2015-07-28 21:31 ` [PATCH 09/11] staging: rtl8192e: Fix IW_IOCTL macro Mateusz Kulikowski
2015-07-28 21:31 ` [PATCH 10/11] staging: rtl8192e: Drop large switch in rtl92e_config_rf Mateusz Kulikowski
2015-07-28 21:31 ` [PATCH 11/11] staging: rtl8192e: probe: iounmap mmio when probe fails Mateusz Kulikowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438119107-26176-9-git-send-email-mateusz.kulikowski@gmail.com \
--to=mateusz.kulikowski@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®