From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752507AbbG2QcD (ORCPT ); Wed, 29 Jul 2015 12:32:03 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:38636 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803AbbG2QcB (ORCPT ); Wed, 29 Jul 2015 12:32:01 -0400 Message-ID: <1438187516.20182.95.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH 1/2] net: Export __netdev_alloc_frag() to allow gfp_mask flags From: Eric Dumazet To: WingMan Kwok Cc: davem@davemloft.net, m-karicheri2@ti.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Reece R. Pollack" Date: Wed, 29 Jul 2015 18:31:56 +0200 In-Reply-To: <1438182653-2136-1-git-send-email-w-kwok2@ti.com> References: <1438182653-2136-1-git-send-email-w-kwok2@ti.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-07-29 at 11:10 -0400, WingMan Kwok wrote: > This patch makes the function __netdev_alloc_frag() non-static and > exports it so that drivers that need to specify additional flags, > such as __GFP_DMA, can use it. The currently exported function, > netdev_alloc_frag() doesn't allow passing in gfp_mask flags. > > Signed-off-by: WingMan Kwok > Signed-off-by: Reece R. Pollack > --- > include/linux/skbuff.h | 1 + > net/core/skbuff.c | 3 ++- > 2 files changed, 3 insertions(+), 1 deletion(-) You can not do this. __napi_alloc_frag() uses __alloc_page_frag() using a per cpu reserve. This per cpu reserve would be shared by regular GFP_ATOMIC and your __GFP_DMA allocations.