From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754179AbbG3CXm (ORCPT <rfc822;w@1wt.eu>);
	Wed, 29 Jul 2015 22:23:42 -0400
Received: from mailgw02.mediatek.com ([210.61.82.184]:35567 "EHLO
	mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
	with ESMTP id S1752424AbbG3CXk (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 29 Jul 2015 22:23:40 -0400
X-Listener-Flag: 11101
Message-ID: <1438223013.17770.42.camel@mtksdaap41>
Subject: Re: [PATCH v5 06/10] clk: mediatek: mt8173: Fix enabling of
 critical clocks
From: James Liao <jamesjj.liao@mediatek.com>
To: Stephen Boyd <sboyd@codeaurora.org>
CC: Matthias Brugger <matthias.bgg@gmail.com>,
        Mike Turquette <mturquette@baylibre.com>,
        Heiko Stubner <heiko@sntech.de>, <srv_heupstream@mediatek.com>,
        Daniel Kurtz <djkurtz@chromium.org>,
        "Ricky Liang" <jcliang@chromium.org>, Rob Herring <robh+dt@kernel.org>,
        "Sascha Hauer" <kernel@pengutronix.de>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>,
        Sascha Hauer <s.hauer@pengutronix.de>
Date: Thu, 30 Jul 2015 10:23:33 +0800
In-Reply-To: <20150730002754.GG3159@codeaurora.org>
References: <1438152754-11970-1-git-send-email-jamesjj.liao@mediatek.com>
	 <1438152754-11970-7-git-send-email-jamesjj.liao@mediatek.com>
	 <20150730002754.GG3159@codeaurora.org>
Content-Type: text/plain; charset="us-ascii"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MTK: N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Stephen,

On Wed, 2015-07-29 at 17:27 -0700, Stephen Boyd wrote:
> On 07/29, James Liao wrote:
> > From: Sascha Hauer <s.hauer@pengutronix.de>
> > 
> > On the MT8173 the clocks are provided by different units. To enable
> > the critical clocks we must be sure that all parent clocks are already
> > registered, otherwise the parents of the critical clocks end up being
> > unused and get disabled later.
> > 
> > On MT8173, for example, it is the CLK_TOP clocks that have CLK_APMIXED
> > PLLs as their parents, so we cannot enable the CLK_TOP critical clocks
> > until the CLK_APMIXED clocks have all been registered.
> > 
> > To find a place where all parents are registered we try each time
> > after we've registered some clocks if all known providers are present
> > now and only then we enable the critical clocks.
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > Signed-off-by: James Liao <jamesjj.liao@mediatek.com>
> > ---
> 
> Please move up to v4.2-rc2 so that this patch can be dropped. I
> already applied this and sent it off to Linus so it's in -rc2.

OK. I'll rebase to v4.2-rc2 in next patchset.


Best regards,

James