mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Vlad Dogaru <vlad.dogaru@intel.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@pengutronix.de
Subject: Re: [PATCH 2/7] iio: bmg160: Use i2c regmap instead of direct i2c access
Date: Thu, 30 Jul 2015 12:49:28 +0200	[thread overview]
Message-ID: <1438253368.15571.31.camel@tiscali.nl> (raw)
In-Reply-To: <20150729183738.GL30895@pengutronix.de>

On wo, 2015-07-29 at 20:37 +0200, Markus Pargmann wrote:
> On Wed, Jul 29, 2015 at 03:46:04PM +0200, Markus Pargmann wrote:
> > +struct regmap_config bmg160_regmap_i2c_conf = {
> 
> This should probably be static const ...

Likewise for "bmg160_regmap_conf", which you add in 7/7, right?

Thanks,


Paul Bolle

  reply	other threads:[~2015-07-30 10:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-29 13:46 [PATCH 0/7] iio: bmg160: Add SPI connection Markus Pargmann
2015-07-29 13:46 ` [PATCH 1/7] iio: bmg160: IIO_BUFFER and IIO_TRIGGERED_BUFFER are required Markus Pargmann
2015-07-31 19:20   ` Srinivas Pandruvada
2015-08-02 18:30     ` Jonathan Cameron
2015-07-29 13:46 ` [PATCH 2/7] iio: bmg160: Use i2c regmap instead of direct i2c access Markus Pargmann
2015-07-29 18:37   ` Markus Pargmann
2015-07-30 10:49     ` Paul Bolle [this message]
2015-07-30 11:44       ` Markus Pargmann
2015-07-31 19:29   ` Srinivas Pandruvada
2015-08-02 17:33     ` Markus Pargmann
2015-07-29 13:46 ` [PATCH 3/7] iio: bmg160: Remove i2c_client from data struct Markus Pargmann
2015-07-29 13:46 ` [PATCH 4/7] iio: bmg160: Use generic dev_drvdata Markus Pargmann
2015-07-29 13:46 ` [PATCH 5/7] iio: bmg160: Remove remaining uses of i2c_client Markus Pargmann
2015-07-29 13:46 ` [PATCH 6/7] iio: bmg160: Separate i2c and core driver Markus Pargmann
2015-07-29 13:46 ` [PATCH 7/7] iio: bmg160: Add SPI driver Markus Pargmann
2015-08-03 10:07   ` Markus Pargmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438253368.15571.31.camel@tiscali.nl \
    --to=pebolle@tiscali.nl \
    --cc=jic23@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpa@pengutronix.de \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=vlad.dogaru@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®