From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752191AbbG3Msu (ORCPT ); Thu, 30 Jul 2015 08:48:50 -0400 Received: from lb2-smtp-cloud3.xs4all.net ([194.109.24.26]:33828 "EHLO lb2-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751384AbbG3Mst (ORCPT ); Thu, 30 Jul 2015 08:48:49 -0400 Message-ID: <1438260522.25464.12.camel@tiscali.nl> Subject: Re: [PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP From: Paul Bolle To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, jassisinghbrar@gmail.com, devicetree@vger.kernel.org Date: Thu, 30 Jul 2015 14:48:42 +0200 In-Reply-To: <20150730114545.GG14642@x1> References: <1437990272-23111-1-git-send-email-lee.jones@linaro.org> <1437990272-23111-4-git-send-email-lee.jones@linaro.org> <1438121215.30903.27.camel@tiscali.nl> <20150730114545.GG14642@x1> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.4 (3.16.4-2.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On do, 2015-07-30 at 12:45 +0100, Lee Jones wrote: > On Wed, 29 Jul 2015, Paul Bolle wrote: > > Besides, if I read sti_max_probe() correctly, without OF support > > loading > > this module won't accomplish much. So what would another way of > > autoloading this module buy you? > > I think this line can be safely removed. Looking at this patch a little more I notice there's no line reading MODULE_DEVICE_TABLE(of, sti_mailbox_match); The three mailbox drivers that currently support OF do have such a line. So "another way of autoloading" was rather sloppy as now I don't see how this driver, if build as a module, will get auto-loaded. Maybe there's an auto-loading mechanism that I'm not aware of here. Or perhaps auto -loading is not needed. Similar question for patch 5/6 and the lack of a line reading MODULE_DEVICE_TABLE(of, mbox_test_match); Thanks, Paul Bolle