From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751433AbbGaLg3 (ORCPT ); Fri, 31 Jul 2015 07:36:29 -0400 Received: from mail-lb0-f171.google.com ([209.85.217.171]:36198 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750994AbbGaLg1 (ORCPT ); Fri, 31 Jul 2015 07:36:27 -0400 From: Ricardo Ribalda Delgado To: Alan Tull , Bryan Wu , Richard Purdie , Jacek Anaszewski , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Jacek Anaszewski Cc: Ricardo Ribalda Delgado Subject: [PATCH v2] leds/led-class: Add missing put_device() Date: Fri, 31 Jul 2015 13:36:21 +0200 Message-Id: <1438342581-9763-1-git-send-email-ricardo.ribalda@gmail.com> X-Mailer: git-send-email 2.4.6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Devices found by class_find_device must be freed with put_device(). Otherwise the reference count will not work properly. Fixes: a96aa64cb572 ("leds/led-class: Handle LEDs with the same name") Reported-by: Alan Tull Signed-off-by: Ricardo Ribalda Delgado --- Thanks Alan for the initial report and Jacek for the review v2: Changes from Jacek Anaszewski If ret <= len device was not relased drivers/leds/led-class.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index beabfbc6f7cd..ca51d58bed24 100644 --- a/drivers/leds/led-class.c +++ b/drivers/leds/led-class.c @@ -228,12 +228,15 @@ static int led_classdev_next_name(const char *init_name, char *name, { unsigned int i = 0; int ret = 0; + struct device *dev; strlcpy(name, init_name, len); - while (class_find_device(leds_class, NULL, name, match_name) && - (ret < len)) + while ((ret < len) && + (dev = class_find_device(leds_class, NULL, name, match_name))) { + put_device(dev); ret = snprintf(name, len, "%s_%u", init_name, ++i); + } if (ret >= len) return -ENOMEM; -- 2.4.6