From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751396AbbGaMYu (ORCPT <rfc822;w@1wt.eu>);
	Fri, 31 Jul 2015 08:24:50 -0400
Received: from lb2-smtp-cloud3.xs4all.net ([194.109.24.26]:53987 "EHLO
	lb2-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1750910AbbGaMYt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 31 Jul 2015 08:24:49 -0400
Message-ID: <1438345486.13223.19.camel@tiscali.nl>
Subject: checkpatch warns about Fixes: lines
From: Paul Bolle <pebolle@tiscali.nl>
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org
Date: Fri, 31 Jul 2015 14:24:46 +0200
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.16.4 (3.16.4-2.fc22) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Andy, Joe,

Checkpatch (as shipped in today's linux-next) warns about "Fixes:"
lines:

WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#10: 
Fixes: 75722d3992f5 ("[PATCH] ppc64: Thermal control for SMU based machines")

ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 75722d3992f5 ("[PATCH] ppc64: Thermal control for SMU based machines")'
#10: 
Fixes: 75722d3992f5 ("[PATCH] ppc64: Thermal control for SMU based machines")

total: 1 errors, 1 warnings, 8 lines checked

Your patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Both warnings seem false positives. "Fixes:" lines should be one line,
shouldn't they, and I think I did use the correct commit description
style here.

Thanks,


Paul Bolle