mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Irina Tirdea <irina.tirdea@intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Bastien Nocera <hadess@hadess.net>,
	linux-input@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	Octavian Purdila <octavian.purdila@intel.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Irina Tirdea <irina.tirdea@intel.com>
Subject: [PATCH v4 0/8] Goodix touchscreen enhancements
Date: Fri, 31 Jul 2015 20:42:04 +0300	[thread overview]
Message-ID: <1438364532-27150-1-git-send-email-irina.tirdea@intel.com> (raw)

Add several enhancements to the Goodix touchscreen driver.

I have added the esd_timeout DT property only for initialization to
get more feedback on this variant of the ESD patch.

Bastien, I have considered that both your boards (specified for rotated
screen quirk) have the reset pin declared first in the ACPI table.
Please let me know if that is correct.

I have also added an entry in sysfs to dump the config and a script that will
help create a new config for the device, if you want to look into the problem
with the Baytrail pinctrl warning.

Thanks,
Irina

Changes in v4:
 - use dmi quirk to determine the order of irq and reset pins
 - use actual config length depending on device
 - add sysfs interface to dump config
 - initialize esd timeout from ACPI/DT propery

Changes in v3:
 - dropped the first 3 patches that got merged
 - handle -EPROBE_DEFER and -ENOENT for gpio pins
 - skip functionality depending on the gpio pins if the pins are not
properly initialized from ACPI/DT (reset, write config, power management,
ESD)
 - dropped #ifdef CONFIG_PM_SLEEP and annotated with __maybe_unused instead
 - use sysfs property to set ESD timeout instead of ACPI/DT property
 - use request_firmware_nowait to read configuration firmware and use defaults
if firmware is not found
 - use ACPI IDs to determine the order of the GPIO pins in the ACPI tables
(interrupt pin first or reset pin first)

Changes in v2:
 - use request_firmware instead of ACPI/DT property for config
 - dropped "input: goodix: add ACPI IDs for GT911 and GT9271" patch
 - add ACPI DSDT excerpt in commit message where necessary
 - add comments for suspend/resume sleep values
 - dropped the checkpatch fixes that did not make sense
 - added Bastien's ack to the first patch

Irina Tirdea (8):
  Input: goodix - reset device at init
  Input: goodix - use actual config length for each device type
  Input: goodix - write configuration data to device
  Input: goodix - add power management support
  Input: goodix - use goodix_i2c_write_u8 instead of i2c_master_send
  Input: goodix - add support for ESD
  Input: goodix - add sysfs interface to dump config
  DO NOT APPLY! goodix configuration update helper

 .../bindings/input/touchscreen/goodix.txt          |  11 +
 drivers/input/touchscreen/goodix.c                 | 652 +++++++++++++++++++--
 tools/touch-goodix-generate-fw.sh                  |  39 ++
 3 files changed, 665 insertions(+), 37 deletions(-)
 create mode 100755 tools/touch-goodix-generate-fw.sh

-- 
1.9.1


             reply	other threads:[~2015-07-31 17:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-31 17:42 Irina Tirdea [this message]
2015-07-31 17:42 ` [PATCH v4 1/8] Input: goodix - reset device at init Irina Tirdea
2015-07-31 17:42 ` [PATCH v4 2/8] Input: goodix - use actual config length for each device type Irina Tirdea
2015-07-31 17:42 ` [PATCH v4 3/8] Input: goodix - write configuration data to device Irina Tirdea
2015-07-31 17:42 ` [PATCH v4 4/8] Input: goodix - add power management support Irina Tirdea
2015-07-31 17:42 ` [PATCH v4 5/8] Input: goodix - use goodix_i2c_write_u8 instead of i2c_master_send Irina Tirdea
2015-07-31 17:42 ` [PATCH v4 6/8] Input: goodix - add support for ESD Irina Tirdea
2015-07-31 17:42 ` [PATCH v4 7/8] Input: goodix - add sysfs interface to dump config Irina Tirdea
2015-07-31 17:42 ` [PATCH v4 8/8] DO NOT APPLY! goodix configuration update helper Irina Tirdea
2015-08-03 10:29 ` [PATCH v4 0/8] Goodix touchscreen enhancements Bastien Nocera
2015-08-04 13:56   ` Tirdea, Irina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438364532-27150-1-git-send-email-irina.tirdea@intel.com \
    --to=irina.tirdea@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hadess@hadess.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=octavian.purdila@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®