mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tal Shorer <tal.shorer@gmail.com>
To: tal.shorer@gmail.com, rostedt@goodmis.org
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: [Patch v3 0/2] tracing: allow disabling compilation of specific trace systems
Date: Sat,  1 Aug 2015 15:27:55 +0300	[thread overview]
Message-ID: <1438432079-11704-1-git-send-email-tal.shorer@gmail.com> (raw)
In-Reply-To: <CAFDyS3Nuq8FPx4z5GW1Ht+NBGd+8O9rjPZ+DaMU1XU1QYgA=2g@mail.gmail.com>

Currently, enabling CONFIG_TRACING on a system comes as all-or-nothing:
either tracepoints for all subsystems are compiled (with CONFIG_TRACING)
or none of them are (without it).

This caused me an unacceptable performance penalty (obviously SOME penalty
was expected, but not one so severe) which made me revert the changes in
configuration.

The first patch in this series modifies the files that actually define the
tracepoint to look for a preprocessor macro NOTRACE and define nops (as if
CONFIG_TRACING was not set) instead of them.

The second patch provides an example of how I see this working, with the
gpio subsystem as the example for absolutely no reason.



Changelog:

v2:
- A comment in tracepoint.h explaining NOTRACE and its use
- Avoid duplication of the test for both NOTRACE and a config option by
defining TRACEPOINTS_ENABLED when both are present and using that to check
whether or not to define tracepoints

v3:
- Fix Patch 1/2 to apply to changes in include/trace/define_trace.h
- Add Linus Walleij's ack to Patch 2/2
- Move the Kconfig option from drivers/gpio/Kconfig to kernel/trace/Kconfig
This was done to group up all TRACING_EVENTS_* options together in the
future to ease disabling everything you don't need.

Tal Shorer (2):
  tracing: allow disabling compilation of specific trace systems
  tracing: gpio: add Kconfig option for enabling/disabling trace events

 include/linux/tracepoint.h   | 17 ++++++++++++++---
 include/trace/define_trace.h |  2 +-
 include/trace/events/gpio.h  |  4 ++++
 kernel/trace/Kconfig         |  7 +++++++
 4 files changed, 26 insertions(+), 4 deletions(-)

-- 
2.4.6


  reply	other threads:[~2015-08-01 12:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-20 20:21 [Patch RFC " Tal Shorer
2015-06-20 20:21 ` [Patch RFC 1/2] " Tal Shorer
2015-07-13 18:34   ` Steven Rostedt
2015-07-13 21:38     ` Tal Shorer
2015-07-16 17:39     ` [PATCH v2 0/2] " Tal Shorer
2015-07-16 17:39       ` [PATCH v2 1/2] " Tal Shorer
2015-07-16 17:39       ` [PATCH v2 2/2] tracing: gpio: add Kconfig option for enabling/disabling trace events Tal Shorer
2015-07-17 18:36         ` Steven Rostedt
2015-07-18 10:12           ` Tal Shorer
2015-08-01 12:27             ` Tal Shorer [this message]
2015-08-01 12:27               ` [Patch v3 1/2] tracing: allow disabling compilation of specific trace systems Tal Shorer
2015-08-01 12:27               ` [Patch v3 2/2] tracing: gpio: add Kconfig option for enabling/disabling trace events Tal Shorer
2015-08-11 19:45                 ` Tal Shorer
2015-09-23 14:54                   ` Tal Shorer
2019-03-27 16:12                 ` Uwe Kleine-König
2019-04-05 17:25                   ` Linus Walleij
2015-07-27 11:57           ` [PATCH v2 " Linus Walleij
2015-06-20 20:21 ` [Patch RFC " Tal Shorer
2015-06-25 20:41 ` [Patch RFC 0/2] tracing: allow disabling compilation of specific trace systems Tal Shorer
2015-06-25 22:25   ` Steven Rostedt
2015-07-06 16:53     ` Tal Shorer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438432079-11704-1-git-send-email-tal.shorer@gmail.com \
    --to=tal.shorer@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®