From: Adrian Hunter <adrian.hunter@intel.com>
To: Chuhong Yuan <hslester96@gmail.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci-pci: Use dev_get_drvdata
Date: Wed, 24 Jul 2019 16:05:47 +0300 [thread overview]
Message-ID: <1438432c-97b4-6a98-e62b-b492f627d060@intel.com> (raw)
In-Reply-To: <20190723124707.24782-1-hslester96@gmail.com>
On 23/07/19 3:47 PM, Chuhong Yuan wrote:
> Instead of using to_pci_dev + pci_get_drvdata,
> use dev_get_drvdata to make code simpler.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-pci-core.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index 4041878eb0f3..d10aceed5bb7 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -1759,8 +1759,7 @@ static const struct sdhci_ops sdhci_pci_ops = {
> #ifdef CONFIG_PM_SLEEP
> static int sdhci_pci_suspend(struct device *dev)
> {
> - struct pci_dev *pdev = to_pci_dev(dev);
> - struct sdhci_pci_chip *chip = pci_get_drvdata(pdev);
> + struct sdhci_pci_chip *chip = dev_get_drvdata(dev);
>
> if (!chip)
> return 0;
> @@ -1773,8 +1772,7 @@ static int sdhci_pci_suspend(struct device *dev)
>
> static int sdhci_pci_resume(struct device *dev)
> {
> - struct pci_dev *pdev = to_pci_dev(dev);
> - struct sdhci_pci_chip *chip = pci_get_drvdata(pdev);
> + struct sdhci_pci_chip *chip = dev_get_drvdata(dev);
>
> if (!chip)
> return 0;
> @@ -1789,8 +1787,7 @@ static int sdhci_pci_resume(struct device *dev)
> #ifdef CONFIG_PM
> static int sdhci_pci_runtime_suspend(struct device *dev)
> {
> - struct pci_dev *pdev = to_pci_dev(dev);
> - struct sdhci_pci_chip *chip = pci_get_drvdata(pdev);
> + struct sdhci_pci_chip *chip = dev_get_drvdata(dev);
>
> if (!chip)
> return 0;
> @@ -1803,8 +1800,7 @@ static int sdhci_pci_runtime_suspend(struct device *dev)
>
> static int sdhci_pci_runtime_resume(struct device *dev)
> {
> - struct pci_dev *pdev = to_pci_dev(dev);
> - struct sdhci_pci_chip *chip = pci_get_drvdata(pdev);
> + struct sdhci_pci_chip *chip = dev_get_drvdata(dev);
>
> if (!chip)
> return 0;
>
next prev parent reply other threads:[~2019-07-24 13:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 12:47 Chuhong Yuan
2019-07-24 13:05 ` Adrian Hunter [this message]
2019-07-24 14:08 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438432c-97b4-6a98-e62b-b492f627d060@intel.com \
--to=adrian.hunter@intel.com \
--cc=hslester96@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®