From: Davidlohr Bueso <dave@stgolabs.net>
To: Waiman Long <Waiman.Long@hp.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Scott J Norton <scott.norton@hp.com>,
Douglas Hatch <doug.hatch@hp.com>
Subject: Re: [PATCH v4 1/7] locking/pvqspinlock: Unconditional PV kick with _Q_SLOW_VAL
Date: Sat, 01 Aug 2015 11:01:03 -0700 [thread overview]
Message-ID: <1438452063.2249.98.camel@stgolabs.net> (raw)
In-Reply-To: <1438395724-25910-2-git-send-email-Waiman.Long@hp.com>
On Fri, 2015-07-31 at 22:21 -0400, Waiman Long wrote:
> The smp_store_release() is not a full barrier. In order to avoid missed
> wakeup, we may need to add memory barrier around locked and cpu state
> variables adding to complexity. As the chance of spurious wakeup is very
> low, it is easier and safer to just do an unconditional kick at unlock
> time.
>
> Signed-off-by: Waiman Long <Waiman.Long@hp.com>
Please keep tags from previous versions ;)
next prev parent reply other threads:[~2015-08-01 18:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-01 2:21 [PATCH v4 0/7] locking/qspinlock: Enhance pvqspinlock performance Waiman Long
2015-08-01 2:21 ` [PATCH v4 1/7] locking/pvqspinlock: Unconditional PV kick with _Q_SLOW_VAL Waiman Long
2015-08-01 18:01 ` Davidlohr Bueso [this message]
2015-08-01 20:12 ` Long, Wai Man
2015-08-01 22:29 ` Peter Zijlstra
2015-08-03 18:22 ` Davidlohr Bueso
2015-08-03 18:37 ` Peter Zijlstra
2015-08-03 19:09 ` Davidlohr Bueso
2015-08-03 19:56 ` Peter Zijlstra
2015-08-04 3:26 ` Waiman Long
2015-08-01 2:21 ` [PATCH v4 2/7] locking/pvqspinlock: Add pending bit support Waiman Long
2015-08-03 18:37 ` Davidlohr Bueso
2015-08-03 21:30 ` Waiman Long
2015-08-01 2:22 ` [PATCH v4 3/7] locking/pvqspinlock: Collect slowpath lock statistics Waiman Long
2015-08-01 2:22 ` [PATCH v4 4/7] locking/pvqspinlock, x86: Optimize PV unlock code path Waiman Long
2015-08-01 2:22 ` [PATCH v4 5/7] locking/pvqspinlock: Enable deferment of vCPU kicking to unlock call Waiman Long
2015-08-01 2:22 ` [PATCH v4 6/7] locking/pvqspinlock: Allow vCPUs kick-ahead Waiman Long
2015-08-01 2:22 ` [PATCH v4 7/7] locking/pvqspinlock: Queue node adaptive spinning Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438452063.2249.98.camel@stgolabs.net \
--to=dave@stgolabs.net \
--cc=Waiman.Long@hp.com \
--cc=doug.hatch@hp.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=scott.norton@hp.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®