From: "Ha, Tristram" <Tristram.Ha@Micrel.Com>
To: "Stephen Hemminger" <shemminger@vyatta.com>
Cc: "Dave Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2.6.33 4/4] net: Add PCI vendor and device ids for Micrel KSZ8841/2 PCI devices
Date: Thu, 4 Feb 2010 18:55:31 -0800 [thread overview]
Message-ID: <14385191E87B904DBD836449AA30269D5CC333@MORGANITE.micrel.com> (raw)
In-Reply-To: <20100204154004.44e3d607@nehalam>
Stephen Hemminger wrote:
> On Thu, 4 Feb 2010 15:28:29 -0800
> "Ha, Tristram" <Tristram.Ha@Micrel.Com> wrote:
>
>> From: Tristram Ha <Tristram.Ha@micrel.com>
>>
>> Add PCI vendor and device ids for Micrel KSZ8841/2 PCI devices.
>>
>> Signed-off-by: Tristram Ha <Tristram.Ha@micrel.com> ---
>> This is a resubmission of the Micrel KSZ8841/2 PCI Ethernet driver.
>>
>> --- linux-2.6.33-rc5.old/include/linux/pci_ids.h 2010-01-21
15:31:35.000000000 -0800
>> +++ linux-2.6.33-rc5.new/include/linux/pci_ids.h 2010-01-29
10:38:53.000000000 -0800 @@ -2199,6
>> +2199,12 @@ #define PCI_VENDOR_ID_NETCELL 0x169c
>> #define PCI_DEVICE_ID_REVOLUTION 0x0044
>>
>> +#define PCI_VENDOR_ID_MICREL_KS 0x16c6
>> +#define PCI_DEVICE_ID_MICREL_KS8692 0x8692
>> +#define PCI_DEVICE_ID_MICREL_KS8695 0x8695
>> +#define PCI_DEVICE_ID_MICREL_KS8841 0x8841
>> +#define PCI_DEVICE_ID_MICREL_KS8842 0x8842
>> +
>> #define PCI_VENDOR_ID_CENATEK 0x16CA
>> #define PCI_DEVICE_ID_CENATEK_IDE 0x0001
>>
>
> Current practice is to NOT update this file and instead keep constants
in the individual driver.
It seems I received conflicted recommendation from Alan Cox:
>> >> +#define PCI_VENDOR_ID_KS884X 0x16C6
>> >> +#define PCI_DEVICE_ID_KS8841 0x8841
>> >> +#define PCI_DEVICE_ID_KS8842 0x8842
>> >
>> > Those belong in the pci device id header.
>> >
>> >
>>
>> I do not quite understand your suggestion. Do I need to put those
IDs
>> in one of the kernel headers?
>
> Into include/linux/pci_ids.h
So I do not need to update pci_ids.h with even the PCI vendor ID?
next prev parent reply other threads:[~2010-02-05 2:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 23:28 Ha, Tristram
2010-02-04 23:40 ` Stephen Hemminger
2010-02-05 2:55 ` Ha, Tristram [this message]
2010-02-05 4:27 ` David Miller
2010-02-04 23:40 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2010-01-29 22:45 Ha, Tristram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14385191E87B904DBD836449AA30269D5CC333@MORGANITE.micrel.com \
--to=tristram.ha@micrel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®