From: Adrian Remonda <adrianremonda@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: adrianremonda@gmail.com, gregkh@linuxfoundation.org,
christian.gromm@microchip.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCHv2 5/6] Staging: most: static keyword missing
Date: Sun, 2 Aug 2015 22:02:27 +0200 [thread overview]
Message-ID: <1438545748-30409-6-git-send-email-adrianremonda@gmail.com> (raw)
In-Reply-To: <1438545748-30409-1-git-send-email-adrianremonda@gmail.com>
This is a patch to the most/aim_cdev.c file. It makes several
local functions and structures static to prevent global visibility.
Signed-off-by: Adrian Remonda <adrianremonda@gmail.com>
---
drivers/staging/most/aim-cdev/cdev.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/most/aim-cdev/cdev.c b/drivers/staging/most/aim-cdev/cdev.c
index d5fb4a0e0818..047acfbef793 100644
--- a/drivers/staging/most/aim-cdev/cdev.c
+++ b/drivers/staging/most/aim-cdev/cdev.c
@@ -49,7 +49,7 @@ static struct list_head channel_list;
static spinlock_t ch_list_lock;
-struct aim_channel *get_channel(struct most_interface *iface, int id)
+static struct aim_channel *get_channel(struct most_interface *iface, int id)
{
struct aim_channel *channel, *tmp;
unsigned long flags;
@@ -288,7 +288,7 @@ static const struct file_operations channel_fops = {
* This frees allocated memory and removes the cdev that represents this
* channel in user space.
*/
-int aim_disconnect_channel(struct most_interface *iface, int channel_id)
+static int aim_disconnect_channel(struct most_interface *iface, int channel_id)
{
struct aim_channel *channel;
unsigned long flags;
@@ -328,7 +328,7 @@ int aim_disconnect_channel(struct most_interface *iface, int channel_id)
* This searches for the channel linked to this MBO and stores it in the local
* fifo buffer.
*/
-int aim_rx_completion(struct mbo *mbo)
+static int aim_rx_completion(struct mbo *mbo)
{
struct aim_channel *channel;
@@ -355,7 +355,7 @@ int aim_rx_completion(struct mbo *mbo)
*
* This wakes sleeping processes in the wait-queue.
*/
-int aim_tx_completion(struct most_interface *iface, int channel_id)
+static int aim_tx_completion(struct most_interface *iface, int channel_id)
{
struct aim_channel *channel;
@@ -375,7 +375,7 @@ int aim_tx_completion(struct most_interface *iface, int channel_id)
return 0;
}
-struct most_aim cdev_aim;
+static struct most_aim cdev_aim;
/**
* aim_probe - probe function of the driver module
@@ -389,7 +389,7 @@ struct most_aim cdev_aim;
*
* Returns 0 on success or error code otherwise.
*/
-int aim_probe(struct most_interface *iface, int channel_id,
+static int aim_probe(struct most_interface *iface, int channel_id,
struct most_channel_config *cfg,
struct kobject *parent, char *name)
{
@@ -462,7 +462,7 @@ error_alloc_channel:
return retval;
}
-struct most_aim cdev_aim = {
+static struct most_aim cdev_aim = {
.name = "cdev",
.probe_channel = aim_probe,
.disconnect_channel = aim_disconnect_channel,
--
2.1.4
next prev parent reply other threads:[~2015-08-02 20:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-02 20:02 [PATCHv2 0/6] Staging: most: several warnings fix reported by sparse Adrian Remonda
2015-08-02 20:02 ` [PATCHv2 1/6] Staging: most: static keyword missing Adrian Remonda
2015-08-02 20:02 ` [PATCHv2 2/6] Staging: most: Fix sparse warning "Using plain integer as NULL pointer" Adrian Remonda
2015-08-02 20:02 ` [PATCHv2 3/6] Staging: most: static keyword missing Adrian Remonda
2015-08-02 20:02 ` [PATCHv2 4/6] Staging: most: Fix sparse warning "Using plain integer as NULL pointer" Adrian Remonda
2015-08-02 20:02 ` Adrian Remonda [this message]
2015-08-02 20:02 ` [PATCHv2 6/6] " Adrian Remonda
2015-08-02 21:10 ` [PATCHv2 0/6] Staging: most: several warnings fix reported by sparse Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438545748-30409-6-git-send-email-adrianremonda@gmail.com \
--to=adrianremonda@gmail.com \
--cc=christian.gromm@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®