From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753057AbbHCLKj (ORCPT ); Mon, 3 Aug 2015 07:10:39 -0400 Received: from mail-by2on0141.outbound.protection.outlook.com ([207.46.100.141]:32751 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752347AbbHCLKh (ORCPT ); Mon, 3 Aug 2015 07:10:37 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none; Date: Mon, 3 Aug 2015 19:10:32 +0800 From: Chenhui Zhao Subject: Re: [PATCH] powerpc/85xx: add sleep and deep sleep support To: Scott Wood CC: , , Message-ID: <1438600232.7515.0@remotesmtp.freescale.net> In-Reply-To: <1438397837.2097.4.camel@freescale.com> References: <1437741961-6663-1-git-send-email-chenhui.zhao@freescale.com> <1438397837.2097.4.camel@freescale.com> X-Mailer: geary/0.10.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD037;1:eIdkGQ1VPUVYpPrKOStNvERz7s8oO+go3p0Jl5bU5rH7M0Tr03pGk8bgjbrCstSypNRewmnVyW+3PuWiUVCQn9EShi4xA73/5WlOIIPRPfaL03ZrYlKWt8Hq56cNy1K63hBmZWvQiCdHfMX1lDEVvOOoajcI68pQitn1Z2qJfI6hzhnyXEnrIQrLTqWYFSgqWAUeElz6DpIDs3cF2drxTEuJZC5lSupsuukWtqDh2vI21tb5/9ynv2Vv+wEo1VIvSRs+oBMxOyrex8E9EqW036Qw3BkjnyukNsidvEB8W4Yn4jcoVZXhBKplpqCZnw/8wpossgNXnFw5D06RdME34w== X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(339900001)(199003)(377454003)(377424004)(24454002)(189002)(23676002)(50466002)(47776003)(105606002)(77096005)(106466001)(85426001)(86362001)(76176999)(87936001)(50986999)(2950100001)(189998001)(50226001)(5001920100001)(104016003)(62966003)(110136002)(77156002)(107886002)(6806004)(19580395003)(5001960100002)(92566002)(88526003)(46102003)(4001450100002)(19580405001)(4001430100001);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR0301MB1286;H:az84smr01.freescale.net;FPR:;SPF:Fail;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB1286;2:sWK8+WI8dRSB0WJSdIbhv48fP5AR0MmZpUBMl0Nntpdurloe2stgp+A1IeU8gZDQj2yxAEFf8kJ+76ErcfKVxlRaxnfvbFqOtB1duzV4J/lDYMgaII9EH/c3809auOFM0zEQnfhuY8nHAh0u4pv6Ohs/K6bVvfRduew6UXQWhM4=;3:gius9gl0TvL8rr028jGOWWCOZbuJnrKSFjCujsWrjtC6LbHJsxSM+8ln5VmHuOWOyx7qKu6o2LpISBXqRZUoF0fXHTGhSFTQFIp3ZKJ/Cfg1WUivvZqtIaH1GuxkwppegXe9Mrf6Gz8Ol8g+IP6wMyXu49Fxi+tyMaOqPWUCEcFLo+YGBiOrJOewrMra5Lim53bXTuUeSO0cQNGm7mI12A5XMAC9fPRO2YJrsaPE6yo=;25:HMk4fAHNh4ZVJfvItqqKUInIZlBRG4DumiZKtf2LZOT7zf4R9aaahN55z8yOQaDjXR0a8GXK6t+4+7Kiim+NAKo9/Yo1lptbLQdmDd//F4yAelScGDRF8RSs/Ev8genXAodya5yeonCUSCS5BJA1/o0J/mwb2iMQPVnsqPyKMvYlbN1b8vKaj7VwYPNABh5adRzID0Nn9Lf37nI7U7M3+ezxJfDiUSM4zP5GnD6e0rddf7GFxB4qcVbhTP7VUJRuMmOqQCEhHaXWFdGkIRJs2w== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB1286; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB1286;20:miLx7NfwY7OxV8k45i7QXLLkWHk9dz/eHwynLLfeLnFuren/K34MXPf3Z++Vb99wZLCf+d1L+1S4Wn545ZkiZBspjVWXA76aItm5BQHkyjmBDfkANjcKfi/fADQ9sTUGOO4WbtHJvnj6Ptdi75/T1E5s7+QwZP3WaU46Dq9gGfaQFvamkV1sQ38Zp+LL7pkexFxiGerdmFvgNDkiOZN4ApjnxoqQRtWYubkmb2QcETW3br4R5egvnavPSCUOdztcvBJUcyiG8NoZ4iFgzFnVviV/NPJ+A/T0XX0YrtFMJaYaQ28VZglnnTtQMFke6p/KhMzK+PxX0xDipO2nMu6L4pcmD/iRMSHmzlmGmZIBzZw=;4:/rJjZ+5NAM8jfDhTrEN+zoVMbPY86TKplVexOsfnLYXeKFkpSHBagUZYt/G1+Ij4/BHFM0awlsB7ovDPqcNLFKZMqqLZTwmt01G7KsBNaR2IJNp8pVRng3GBi9b81bmJYdUzSMDYgQz0Q+zPvE7DyQ4H4RNkkKjPS/8gV0vLVIauBkB2h2vEB3nCUnmgn+rM65NkHzQFmNGYK+qHeKydvbADY654tTdL5OE+d7zfgy+6c0lJuxJZeUd9ykr0ZFkID4iXNfW/M/uMNcJ4/TIiDpFSvAYChP1eT6/YJNU2l2k= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BY1PR0301MB1286;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB1286; X-Forefront-PRVS: 0657D528EC X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjAzMDFNQjEyODY7MjM6VFVCTGRsTE5QOStQR2h4dHd6Vk9OVU5l?= =?utf-8?B?aWdUaGVKSzM3cGIvYWVRM3kxSklTSTMvT3VHdDZvZ3ZsblBhWHFjNXVnM2Na?= =?utf-8?B?VGNDbkJucjlmWDNMN3Y5MGRLY2ZYdHh1ZmF3Yk04N3hsQm9KYTArUFprTkxv?= =?utf-8?B?RVFkMEhDaXRjU2FLa0JVdTgvbGltYm05UFd2UkVLRHJ1SFRuL2NmMTltckVX?= =?utf-8?B?U085L2Z3K2U3NTR1bUt1OWc3a0ErWCt0Mnp5UlRtTFZ0R1oxZ0xJZUYvbzFE?= =?utf-8?B?S0JSQmtZeCtrQlVYRFhVSlRFTy96dzdZaGl5TmJXWDVMSHVmZ3FWQ1RrM1g5?= =?utf-8?B?Q040T1dlQW5CUmFUcVNZemo5SjFGNEtlTllRaVVwUjFlQlZHRlYvTEhXWTYw?= =?utf-8?B?UGhSWHA4TG5WTmxSUmYzSy9zMm41bk1kZGtWV1ZBcmM0REVSNWd0NnFGUGEv?= =?utf-8?B?YkhMVms2ckg4RkhTaEdwSjZRMHh6T084RTFIUXhQK2JIYnJRRjBwQjdWZERV?= =?utf-8?B?RXQyUUdkUTRSeHRJSWNLd3laL3p4YXNPK1R6WFZHb1U5MzB5TC9OcUo2K2s1?= =?utf-8?B?U3p6VldRTGV0QzgrSFdjV2Fwd0dhZHorMjBld1pJY3VWaFIzUFFzOWdvMVFn?= =?utf-8?B?VFB2T3I5MTB3a2ZTK0w0cE9jVkpycit4RlB4WEo0S2tyc1lCcmtxRzhyWkY1?= =?utf-8?B?dVoyMGpXdlNRdkJSSkpROFFwdVVJYmgzUy9jYmJRaHRmWUZjT0dreFphODZm?= =?utf-8?B?WmhnVXc3UjBjbEVyc3A1UEwyWUZ1enhtNzJtbW9XQnBUWWNoSFpsajRqR2w0?= =?utf-8?B?TkZpTk1GckJoNllacmtBS00vY1k1dE1JNWpwdzFHVUd6MjBPQkRaRVRHQ0hn?= =?utf-8?B?S0cvNW5sT2YvWW5vL0ZKakhGUTFTOW9LWFRIWTBLTzhpamZTZ3J5bU5oYnZn?= =?utf-8?B?TzVNN0RNNmtDR3lWNm1QYTY5T2J6MFVyYTZnd0RxV0g1OGUxc2svcVIxVm51?= =?utf-8?B?TlVvS2pzNFdlRXdEZHVWYkxoSFNuelZwZlZVbHJPRkRMQ2pJSFpmN3MwRFNu?= =?utf-8?B?Z2hWVzE0NE5Fanh2RWpyWVVpUU13eGYwOFRiWlRweFc2aG5aZ014YjVJeUhJ?= =?utf-8?B?YzJMRGpWMGV1NnNXanVXc2NMdlFZRG5nTEl1dm9lL043c0kySFRBWTBNaXkv?= =?utf-8?B?L1FlTTB4eFZjdnhzbkd4WlVwYk1raWxSWmVDTC9idldwWG5odDRYZUliUmZm?= =?utf-8?B?MkNKTFY4Zk5YemZZek1OdW4xZ2tubzUxK29qZ2VQQzM5SlpmMVZnL0VEUGJs?= =?utf-8?B?ZnFaZlh5eDhqT0RUaktiSjV6aEZwTGtSMkNGV0NwejBJYWhudlpnOGJXNjFX?= =?utf-8?Q?fPsAJho74G?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB1286;5:54JAvLN5ye+/hniJ0ia1jRLg+peWo0wjENzRDxoKjIY10YdVbcINXkp05k4+Pnhr3maMzyzQQ4ZuyNT9aRyjf2kt1EQ1fhlHN+bZhDDb2YrGJgW+Cbfc6q4EebTPVLhKCKo7GATak8qomIanlTYbxA==;24:dpkt23sSFG5GUvmU/djkpQdpi9VY8sISs6Iaa164WfhkM8IEad/sHSN2g2RaCgVN6ZkvzsdCsACKMLNhqgrDNeGDs4suc7h6r9RTDpdVDaA=;20:yBZ9zTfQ/Wkl+VKsAT7NVnM8i2ETY1+r2aEkYEJRLs6lpFk6aGlYfNGeHPsijDBV7IEl47udO6LcwWpPmfuElg== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2015 11:10:34.1496 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0301MB1286 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 1, 2015 at 10:57 AM, Scott Wood wrote: > On Fri, 2015-07-24 at 20:46 +0800, Chenhui Zhao wrote: >> +static void mpc85xx_pmc_set_wake(struct device *dev, void *enable) >> { >> int ret; >> + u32 value[2]; >> + >> + if (!device_may_wakeup(dev)) >> + return; >> + >> + if (!pmc_regs) { >> + dev_err(dev, "%s: PMC is unavailable\n", __func__); >> + return; >> + } >> + >> + ret = of_property_read_u32_array(dev->of_node, "sleep", >> value, 2); > > This will crash on any device without an of_node. Add this before this line: if (!dev->of_node) return; > > >> + if (ret) { >> + dev_dbg(dev, "%s: Can not find the \"sleep\" >> property.\n", >> + __func__); >> + return; >> + } >> + >> + if (*(int *)enable) >> + pmc_pmcdr_mask &= ~value[1]; >> + else >> + pmc_pmcdr_mask |= value[1]; >> + >> + if ((value[1] & 0xe0) && (pmc_flag & PMC_LOSSLESS)) >> + pmc_powmgtcsr = POWMGTCSR_LOSSLESS; >> +} > > What is 0xe0? > > -Scott This is a mask value for the register PMCDR, which includes all bits corresponding to eTSEC. Will use a macro instead. -Chenhui