From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932439AbbHCVXD (ORCPT ); Mon, 3 Aug 2015 17:23:03 -0400 Received: from mail-bn1on0111.outbound.protection.outlook.com ([157.56.110.111]:40544 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932472AbbHCVW7 (ORCPT ); Mon, 3 Aug 2015 17:22:59 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1438636971.2097.66.camel@freescale.com> Subject: Re: [PATCH 3/4] powerpc: pm: add EPU FSM configuration for deep sleep From: Scott Wood To: Chenhui Zhao CC: , , Date: Mon, 3 Aug 2015 16:22:51 -0500 In-Reply-To: <1438603291.7515.4@remotesmtp.freescale.net> References: <1438347186-8462-1-git-send-email-chenhui.zhao@freescale.com> <1438347186-8462-3-git-send-email-chenhui.zhao@freescale.com> <1438389711.19345.99.camel@freescale.com> <1438603291.7515.4@remotesmtp.freescale.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:448:8100:f9f:12bf:48ff:fe84:c9a0] X-ClientProxiedBy: BY2PR07CA046.namprd07.prod.outlook.com (10.141.251.21) To BLUPR03MB1475.namprd03.prod.outlook.com (25.163.81.17) X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1475;2:Z2Eo7g8SRV9MiAJvcDM5SU+rrg0sGd18PUK/7hqQXueztTXAW4FI8lwxwjoprEyJwAX3M981vRXTXcWRJa6suvHKu8ns1V6/reOpGpCTVXuFyGqXF/XC3DE7yAg/CelCgQe1mWT5v6hTM9LG8WhrB1Iu8LC32Cb3f9Ek5ncGXyU=;3:WYV3+UT9JuaoPy1oclJzVDqlXfS4+VO3wSezTeOIC0itrPOM963L70I/OIGVFPWShJxMIP3m7HOmO7k2Owu9SvbMVq7Ft1ikrUNVavbSDeaENyRTiua7c6DLxVGt5zZjaA6bTjEsscwWYdjYE6J8ow==;25:Z0BKeDs5bxMu1XBOw+ER5YFSlCjNrLmPReYZlHqTi579hnBQAbpyfZdAW3dkQ3WUfDMCFNfGHKeW8pg97pn0SFzywioBR3OM0SQOt6TbvNp0NCGSztNvxPs42pwAsDd5LdZsdjksCp/SELAGaehH9FR7Hj21voPTbtRRJ+h2sc/tRuvEnxLX3NobHTSuxjl5PmIcZxBEG9SXtKEyg68YqMuWbgo0UHFNL4n/D0ecHVd0554Ecg3zHCt2rhkRcj02 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1475; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1475;20:LLcuqc6YCBnMTgId9/rCr1ywM+V4IFAqKOC8e2uWzMMyUj3xUqUjATbj/3K6dmLbD/jmLXz7L0qA7pNrSiKkibw16v7NyT+colLw3BLeCuQldFqKr8PNzXLS8wvroSXZ5kt8wOSxg1vX1GIqRClKWI/aYzf5uykxaDgEc1qd3LnEatGpLMUm1E/BM7d9MIcBkfIgw+sOR3IOBK3wJG+ZX2pN2i/dl5ri2SUNYkj/RgLAkogRbzsO1Wg+0M4nwyBxZAX/5gw+YzYsyLTPAEUHoWNXlwVKIcywZsO1uKrdhsvrr86qZM8fMufk00NPZ6fQmaS511wU0fh/RQznz4LkqejY8LucA9OlukO4lwdKcByQRfYQjtSfJhei2L6YT2yC3owo/kNH63w9Thg2sE0riD7PZraK0hje00vmfOxQ1SQGPiazN4DGYO7jWxDeccwl7EP9VlhJx6As4bilBwxmt4OrSSjqunWqqdBF8RrEZ0nevRRoWThA3oFjWx8lYnoR;4:BlJHcnD5ECOFAfj3UP7sVwFfEQ3weVg5L2lTNUDs1OeuoxFFmQBCgjOUesWmSsh3B8Xni3liH/9nEUyZImKsbTYcUPxauDYmwPB8uDmOB7HHCLvaQreQ3hGr4K6vdgUpQDiydpD08z/HmfKxl0dHRSIdaSDDVMsmUOY0+DCvYLrdd25DrDp3vg+Ku30JJ2G4NL/xyFS/m1Aup79G2xEv4qMAR9enwjvVG9YFBP2nVE9J3zr6ZplaTkP9R101o1a2o7Q7u/FePY0Id/tgnJeGsFj7SybS2e9TrRyHInbwId0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BLUPR03MB1475;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1475; X-Forefront-PRVS: 0657D528EC X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(189002)(377424004)(377454003)(199003)(50226001)(46102003)(97736004)(77156002)(47776003)(33646002)(62966003)(92566002)(106356001)(50466002)(42186005)(19580405001)(105586002)(19580395003)(64706001)(103116003)(87976001)(4001540100001)(81156007)(40100003)(5001830100001)(122386002)(76176999)(68736005)(23676002)(5001860100001)(86362001)(110136002)(5820100001)(93886004)(4001450100002)(50986999)(101416001)(107886002)(2950100001)(189998001)(77096005)(5001960100002)(36756003)(5001920100001)(99106002)(3826002)(4001430100001)(5001840100002)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR03MB1475;H:[IPv6:2601:448:8100:f9f:12bf:48ff:fe84:c9a0];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjAzTUIxNDc1OzIzOkhUeVh5VUVsNmJFTGRSYmZERzJVSXhVZjN0?= =?utf-8?B?MXRzTWtlSXNabzdJVTdpdTkzbUhHeXhrQ3pPbjlabGFEUThmbDZMdk0rZmZa?= =?utf-8?B?UlN3bm9PeUJHdzNEWkFueDRMTnMvanRWQ0wwQkJ1TmhObkFwMElsREMzWUJQ?= =?utf-8?B?aUw5MDZVdXIzUXJhT2FxZ05VQi8rTzdaM2p0WjEzQWtHOXdpUGlzMUpDcDVM?= =?utf-8?B?b2hIcEx5eVFFY2NYN1pKU1JUcGpjSkxpQys5bjY3VEMrR2xLQjdTOWdtcEF1?= =?utf-8?B?clVuMGFDNWtvT1VhTC9YRkNwcXpHZEhwUlRLditJNmIwWHE1dFpUa3NqVHBh?= =?utf-8?B?Wnluc0RsbFRuRGFCcUFEd1p2ZnNqWW10TldZcmtLU1pWRk9rcFlMNG9GWnQ4?= =?utf-8?B?SWpoRG05ZlhBSzUzWjk0WktkcFZucXhhUDMrc2NOY2Zjd0x0bjlmUGxvcUxq?= =?utf-8?B?bmdjaEV1VVYrK01NM3VSQ1NhNG93UnVvMFpaanowNWN4bkkxZXV4TEt4OFB3?= =?utf-8?B?LytRcm5vRG1WT0FuamlWL0M2b3VLdXJ4VFZhNm03Z0xESFJpWm16dWtDWU1T?= =?utf-8?B?LzJuanJSM0pJTFFhZW0xUzVDSzlGWXNyRXd5YXkrVEtCaGZGVmRxci9EMHU2?= =?utf-8?B?MWZnbUdiWlNpK1RCNjRCN2JFRmVjQ3laR0NjZUZGS0JROTN1aUhYcVBWWlNE?= =?utf-8?B?TExrK2VwMTd3MHdFNDcwS3NWS3pRR2tlZm1BWTRoZWhJQ0EwcmNCYnl6N2p5?= =?utf-8?B?NnBEYmh0L1FBTUVFV1kvakg3ZjZnV24vcnpTVkQ5T3EvVjV4bE5BUzRsQ0I3?= =?utf-8?B?V29SQzQ1NTFFMTRCNndpK04xZ1NKMlhpbDFJYVlWNmRueGNYazNNdkRCNDhV?= =?utf-8?B?TXNLdldPRk1Celc4NVMvZ0NILzNzcHdNdDlwV0ZPRmE3Um1HVllLTTYzWmUw?= =?utf-8?B?MVlhL01kNStzK1paRU5oN3ZMc3hpK25OZmV3UElpcHZ6UkNHS2pHMFNtdkJD?= =?utf-8?B?TjVpTjlQTEtCWXV0YkUyVy85VXN1OGR5UWN3YmlzUVVQcnRBcnZ6ejBlclA1?= =?utf-8?B?SUM0SmF5amp4NnZKTmlaSHRVaVVaUTZxSGkwWGZlcFdONU0rcTc0WjFDSmE4?= =?utf-8?B?b1hJdUcxKzB1QWU4VmZiYzBHZFdaTmRBMmp4Z3FlbUpkektqREc0N0Nkczhu?= =?utf-8?B?R0lMUVkzQmxJaDBPVGZQTFhBeERpOVY2Zk5PdHBpYXA3S3d5SEMyd3NtdURh?= =?utf-8?B?bFFUb3VpbkNIVU9DN0M1K0NqOW1JeGZnQzJVRVlmd2hlYXdQWnBWQXhsNXNa?= =?utf-8?B?OUpRUUpIdVNlR2FwY2pIdXdreDg1QVhCcVZaR2h3VlJ4RDN2R3RvS1U2WDUy?= =?utf-8?B?cmRIWVNObGw3cmNXamtVSG9oKzAzdE1HcDMveXgxbFlEREtBcDZZTFJ4MC9v?= =?utf-8?B?ZGNaVjBRRG9SRDlxUzBkSXRwc0hZVForNWJxeE9CbnEzNHpkVDJuUkN3NUxW?= =?utf-8?B?ZGFIa0lCNDNSVUtyc3pQaGJNNGkvc1RwbGlkMkpScUx6UXhDV0IvNDhHNTlv?= =?utf-8?B?dWI5M0d1ckZheEhMellBajFuNmZEU00xblgwVTkvWmJPd2xrMTBNdXh0YXdH?= =?utf-8?B?ZzJhbDNSR1NRNUVlTGxaY3hqcjZyNjJUa2dGVmpEVlhMeHBML1ZrOEp0Ujcw?= =?utf-8?B?UFYrb29kcEw3RzNkNE0wU2syTXUrUndGbDNGbU92SmlZb001elo4eHlKc3p5?= =?utf-8?B?Z0JlM1p4QnJpMUMxQTIrNnhHMUNZbFNVSkFGcFppS2RudjMyK21SOWNZb2xs?= =?utf-8?B?QTAxREthTVFWOHBoMXkyVzVzK25xOHpHbHlIN1NiTG9jUHc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1475;5:D3vUMZVK3eBHFACUFzFB4p7b5hZEs590MdTUhgEsPGEJLtaOycm6yZR9kfGQKNIHnMRA/CRlbBpO2uUJwmusFJPGyJZeCQ/WMCjKb0hYBVJPqJLdS0wvdBaFpSo6AoS0aGqUaOE1NiFc2SgaK+2lSg==;24:2h9IRUMbE5/vd31ZAdip1s3Z17ixhcYWOk9NcCxD8Wc+lsOg2ERu4WXYTYZE7UbH/zdMKf0AeU43m9D9Sl6GhxhHEsPcNadE4qTG76csfEU=;20:gFPztwzn8OY7vNSdAhd97qpSUeMeo7JZ9EMUBE9b0qh1htuBIpN8yeva0GIbP8Kp3UgLh+ZohIjUfM1zMmPaKA== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2015 21:22:55.2533 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1475 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-08-03 at 20:01 +0800, Chenhui Zhao wrote: > On Sat, Aug 1, 2015 at 8:41 AM, Scott Wood > wrote: > > On Fri, 2015-07-31 at 20:53 +0800, Chenhui Zhao wrote: > > > In the last stage of deep sleep, software will trigger a Finite > > > State Machine (FSM) to control the hardware precedure, such as > > > board isolation, killing PLLs, removing power, and so on. > > > > > > When the system is waked up by an interrupt, the FSM controls the > > > hardware to complete the early resume precedure. > > > > > > This patch configure the EPU FSM preparing for deep sleep. > > > > > > Signed-off-by: Chenhui Zhao > > > --- > > > arch/powerpc/platforms/85xx/Makefile | 2 +- > > > arch/powerpc/platforms/85xx/sleep_fsm.c | 256 > > > ++++++++++++++++++++++++++++++++ > > > arch/powerpc/platforms/85xx/sleep_fsm.h | 104 +++++++++++++ > > > 3 files changed, 361 insertions(+), 1 deletion(-) > > > create mode 100644 arch/powerpc/platforms/85xx/sleep_fsm.c > > > create mode 100644 arch/powerpc/platforms/85xx/sleep_fsm.h > > > > When I asked why this was in drivers/platform[1], you said it was to > > share > > with LS1, and that the values used were the same -- so why did you > > move it to > > arch/powerpc? > > There are some changes. LS1 will use PSCI (Power State Coordination > Interface) to implement deep sleep. So these code just used by PowerPC. Then remove the comment about the values being usable on ls1021. -Scott