From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754466AbbHFDoL (ORCPT ); Wed, 5 Aug 2015 23:44:11 -0400 Received: from ozlabs.org ([103.22.144.67]:42655 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753966AbbHFDoK (ORCPT ); Wed, 5 Aug 2015 23:44:10 -0400 From: Michael Ellerman To: , apw@canonical.com, joe@perches.com Subject: [PATCH] checkpatch: Don't complain about long "Fixes:" lines Date: Thu, 6 Aug 2015 13:44:08 +1000 Message-Id: <1438832648-31761-1-git-send-email-mpe@ellerman.id.au> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We encourage people to mention the commit they are fixing, if any, using a Fixes line, see SubmittingPatches. Although it's not mentioned explicitly, it's preferable if the Fixes line is not wrapped, so skip Fixes lines when checking for overlength lines. Signed-off-by: Michael Ellerman --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d5c8e9a3a73c..b3139cb1bf9d 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2310,7 +2310,7 @@ sub process { # Check for line lengths > 75 in commit log, warn once if ($in_commit_log && !$commit_log_long_line && - length($line) > 75) { + length($line) > 75 && $line !~ /^\s*Fixes: [0-9a-f]+/i) { WARN("COMMIT_LOG_LONG_LINE", "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr); $commit_log_long_line = 1; -- 2.1.4