mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrzej Hajda <a.hajda@samsung.com>
To: Artem Bityutskiy <dedekind1@gmail.com>,
	Adrian Hunter <adrian.hunter@intel.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: [PATCH 25/31] fs/ubifs: use kmemdup rather than duplicating its implementation
Date: Fri, 07 Aug 2015 09:59:31 +0200	[thread overview]
Message-ID: <1438934377-4922-26-git-send-email-a.hajda@samsung.com> (raw)
In-Reply-To: <1438934377-4922-1-git-send-email-a.hajda@samsung.com>

The patch was generated using fixed coccinelle semantic patch
scripts/coccinelle/api/memdup.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2014320

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
 fs/ubifs/lpt.c | 6 ++----
 fs/ubifs/tnc.c | 3 +--
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/fs/ubifs/lpt.c b/fs/ubifs/lpt.c
index dc9f27e..9a51710 100644
--- a/fs/ubifs/lpt.c
+++ b/fs/ubifs/lpt.c
@@ -1498,11 +1498,10 @@ static struct ubifs_nnode *dirty_cow_nnode(struct ubifs_info *c,
 	}
 
 	/* nnode is being committed, so copy it */
-	n = kmalloc(sizeof(struct ubifs_nnode), GFP_NOFS);
+	n = kmemdup(nnode, sizeof(struct ubifs_nnode), GFP_NOFS);
 	if (unlikely(!n))
 		return ERR_PTR(-ENOMEM);
 
-	memcpy(n, nnode, sizeof(struct ubifs_nnode));
 	n->cnext = NULL;
 	__set_bit(DIRTY_CNODE, &n->flags);
 	__clear_bit(COW_CNODE, &n->flags);
@@ -1549,11 +1548,10 @@ static struct ubifs_pnode *dirty_cow_pnode(struct ubifs_info *c,
 	}
 
 	/* pnode is being committed, so copy it */
-	p = kmalloc(sizeof(struct ubifs_pnode), GFP_NOFS);
+	p = kmemdup(pnode, sizeof(struct ubifs_pnode), GFP_NOFS);
 	if (unlikely(!p))
 		return ERR_PTR(-ENOMEM);
 
-	memcpy(p, pnode, sizeof(struct ubifs_pnode));
 	p->cnext = NULL;
 	__set_bit(DIRTY_CNODE, &p->flags);
 	__clear_bit(COW_CNODE, &p->flags);
diff --git a/fs/ubifs/tnc.c b/fs/ubifs/tnc.c
index 957f575..fa9a20c 100644
--- a/fs/ubifs/tnc.c
+++ b/fs/ubifs/tnc.c
@@ -198,11 +198,10 @@ static struct ubifs_znode *copy_znode(struct ubifs_info *c,
 {
 	struct ubifs_znode *zn;
 
-	zn = kmalloc(c->max_znode_sz, GFP_NOFS);
+	zn = kmemdup(znode, c->max_znode_sz, GFP_NOFS);
 	if (unlikely(!zn))
 		return ERR_PTR(-ENOMEM);
 
-	memcpy(zn, znode, c->max_znode_sz);
 	zn->cnext = NULL;
 	__set_bit(DIRTY_ZNODE, &zn->flags);
 	__clear_bit(COW_ZNODE, &zn->flags);
-- 
1.9.1


  parent reply	other threads:[~2015-08-07  8:00 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-07  7:59 [PATCH 00/31] " Andrzej Hajda
2015-08-07  7:59 ` [PATCH 01/31] arch/arm/mach-lpc32xx: " Andrzej Hajda
2015-09-16  9:52   ` Andrzej Hajda
2015-09-16 10:06     ` Arnd Bergmann
2015-08-07  7:59 ` [PATCH 02/31] arch/ia64/tioce: " Andrzej Hajda
2015-09-16  9:53   ` Andrzej Hajda
2015-08-07  7:59 ` [PATCH 03/31] arch/m68k/bootinfo: " Andrzej Hajda
2015-08-07 10:23   ` Geert Uytterhoeven
2015-08-07  7:59 ` [PATCH 04/31] arch/mips/bcm47xx: " Andrzej Hajda
2015-08-09 20:14   ` Hauke Mehrtens
2015-08-07  7:59 ` [PATCH 05/31] arch/powerpc/nvram: " Andrzej Hajda
2015-08-07 19:46   ` Nathan Fontenot
2015-08-19 23:14   ` [05/31] " Michael Ellerman
2015-08-07  7:59 ` [PATCH 06/31] arch/powerpc/pseries: " Andrzej Hajda
2015-08-07 19:46   ` Nathan Fontenot
2015-08-19 23:14   ` [06/31] " Michael Ellerman
2015-08-07  7:59 ` [PATCH 07/31] arch/x86/microcode: " Andrzej Hajda
2015-08-07 16:30   ` Borislav Petkov
2015-08-07  7:59 ` [PATCH 08/31] arch/x86/intel-mid: " Andrzej Hajda
2015-09-16  9:54   ` Andrzej Hajda
2015-09-17 21:42   ` [tip:x86/platform] arch/x86/intel-mid: Use " tip-bot for Andrzej Hajda
2015-08-07  7:59 ` [PATCH 09/31] crypto: use " Andrzej Hajda
2015-08-07  8:05   ` Herbert Xu
2015-08-07  7:59 ` [PATCH 10/31] clk/mmp: " Andrzej Hajda
2015-08-07 22:17   ` Stephen Boyd
2015-08-07  7:59 ` [PATCH 11/31] cpufreq/sfi: " Andrzej Hajda
2015-08-07  8:58   ` Viresh Kumar
2015-08-07  7:59 ` [PATCH 12/31] drm/amdgpu: " Andrzej Hajda
2015-09-16  9:56   ` Andrzej Hajda
2015-09-16 16:21     ` Christian König
2015-09-21 21:36       ` Alex Deucher
2015-08-07  7:59 ` [PATCH 13/31] memstick: " Andrzej Hajda
2015-09-16  9:57   ` Andrzej Hajda
2015-08-07  7:59 ` [PATCH 14/31] message/fusion: " Andrzej Hajda
2015-09-16 10:01   ` Andrzej Hajda
2015-08-07  7:59 ` [PATCH 15/31] misc/vmw_vmci: " Andrzej Hajda
2015-09-16 10:01   ` Andrzej Hajda
2015-08-07  7:59 ` [PATCH 16/31] net/cavium/liquidio: " Andrzej Hajda
2015-09-16 10:02   ` Andrzej Hajda
2015-08-07  7:59 ` [PATCH 17/31] scsi/aacraid: " Andrzej Hajda
2015-09-16 10:02   ` Andrzej Hajda
2015-08-07  7:59 ` [PATCH 18/31] scsi/aic7xxx: " Andrzej Hajda
2015-09-16 10:02   ` Andrzej Hajda
2015-08-07  7:59 ` [PATCH 19/31] staging/lustre: " Andrzej Hajda
2015-08-07  7:59 ` [PATCH 20/31] fs/cifs: " Andrzej Hajda
2015-09-16 10:03   ` Andrzej Hajda
2015-09-17  5:00   ` Steve French
2015-08-07  7:59 ` [PATCH 21/31] fs/dlm: " Andrzej Hajda
2015-09-16 10:03   ` Andrzej Hajda
2015-08-07  7:59 ` [PATCH 22/31] fs/ntfs: " Andrzej Hajda
2015-09-16 10:04   ` Andrzej Hajda
2015-09-23 10:21   ` Anton Altaparmakov
2015-09-24  8:34     ` Andrzej Hajda
     [not found]     ` <fc4b273eb58a4c33b4e80270a7fd06b1@nebula-exfe-01.nebula.local>
2015-09-24  9:20       ` Anton Altaparmakov
2015-09-24  9:22         ` Anton Altaparmakov
2015-08-07  7:59 ` [PATCH 23/31] fs/ocfs2: " Andrzej Hajda
2015-09-16 10:04   ` Andrzej Hajda
2015-08-07  7:59 ` [PATCH 24/31] fs/omfs: " Andrzej Hajda
2015-08-07 12:22   ` Bob Copeland
2015-09-16 10:05   ` Andrzej Hajda
2015-08-07  7:59 ` Andrzej Hajda [this message]
2015-08-08  9:12   ` [PATCH 25/31] fs/ubifs: " Richard Weinberger
2015-08-10  8:16   ` Artem Bityutskiy
2015-08-07  7:59 ` [PATCH 26/31] net/sched: " Andrzej Hajda
2015-08-07 10:35   ` Daniel Borkmann
2015-08-07  7:59 ` [PATCH 27/31] net/tipc: " Andrzej Hajda
2015-09-16 10:07   ` Andrzej Hajda
2015-09-17  9:58     ` Jon Maloy
2015-09-17  1:19   ` Ying Xue
2015-08-07  7:59 ` [PATCH 28/31] net/xfrm: " Andrzej Hajda
2015-08-12 10:25   ` Steffen Klassert
2015-08-07  7:59 ` [PATCH 29/31] sound/oxfw: " Andrzej Hajda
2015-08-07 12:52   ` [alsa-devel] " Takashi Iwai
2015-08-07  7:59 ` [PATCH 30/31] sound/atom: " Andrzej Hajda
2015-08-07 12:29   ` Mark Brown
2015-08-07  7:59 ` [PATCH 31/31] sound/soc: " Andrzej Hajda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438934377-4922-26-git-send-email-a.hajda@samsung.com \
    --to=a.hajda@samsung.com \
    --cc=adrian.hunter@intel.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=dedekind1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=m.szyprowski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®