From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752071AbbHGK1D (ORCPT ); Fri, 7 Aug 2015 06:27:03 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:56199 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751898AbbHGK1A (ORCPT ); Fri, 7 Aug 2015 06:27:00 -0400 X-AuditID: cbfee61b-f79706d000001b96-bb-55c487f25702 From: Robert Baldyga To: vinod.koul@intel.com Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, k.kozlowski@samsung.com, Robert Baldyga Subject: [PATCH] dmaengine: fix balance of privatecnt inc/dec operations Date: Fri, 07 Aug 2015 12:26:47 +0200 Message-id: <1438943207-4840-1-git-send-email-r.baldyga@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKJMWRmVeSWpSXmKPExsVy+t9jAd1P7UdCDTY1qltMn3qB0WL11L+s Fq9fGFpc3jWHzWLtkbvsFg8O72S3eNm3n8WB3WPxnpdMHn1bVjF6fN4kF8AcxWWTkpqTWZZa pG+XwJXx7eMb5oJDHBVvtvUwNTAuZe9i5OSQEDCR2PbrAhuELSZx4d56IJuLQ0hgKaPEhhfT mSCcn4wSZ1s/s4BUsQnoSGz5PoERxBYRkJDY/qyPHaSIWWALo8T2xmdMIAlhAQ+JKW9aWUFs FgFViaNvesFsXgEXiauXnrFCrJOTOHlsMusERu4FjAyrGCVSC5ILipPSc43yUsv1ihNzi0vz 0vWS83M3MYID45n0DsbDu9wPMQpwMCrx8Cb8OxwqxJpYVlyZe4hRgoNZSYT3bPWRUCHelMTK qtSi/Pii0pzU4kOM0hwsSuK8+iabQoUE0hNLUrNTUwtSi2CyTBycUg2Mm7o8eY/bLl4p9GN6 71IuzR9/za8aJnLrP5weonZO7bfB0SStzrip3sdu2GzrchA2faSxaVlC8R4eURl/x17rCcf5 H83s8yvluvFN2vPgbplJc9VEeRfP2WOwPO/W8inhN01vKDedW7NI5TQwOC/ZHnvrxyXN+VNM 6ESn9IcLHj8WqOsnf3ynxFKckWioxVxUnAgAM3Cc0wgCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch increments privatecnt value and set DMA_PRIVATE in device caps in dma_request_slave_channel() function. This is needed to keep privatecnt increment/decrement balance. As function dma_release_channel() decrements privatecnt counter, we need to increment it when channel is requested. Otherwise privatecnt drops into negatives after few dma_release_channel() calls. Reported-by: Krzysztof Kozlowski Signed-off-by: Robert Baldyga --- drivers/dma/dmaengine.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c index 4a4cce1..3ff284c 100644 --- a/drivers/dma/dmaengine.c +++ b/drivers/dma/dmaengine.c @@ -689,6 +689,10 @@ struct dma_chan *dma_request_slave_channel(struct device *dev, struct dma_chan *ch = dma_request_slave_channel_reason(dev, name); if (IS_ERR(ch)) return NULL; + + dma_cap_set(DMA_PRIVATE, ch->device->cap_mask); + ch->device->privatecnt++; + return ch; } EXPORT_SYMBOL_GPL(dma_request_slave_channel); -- 1.9.1