From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753459AbbHGNgr (ORCPT ); Fri, 7 Aug 2015 09:36:47 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:56748 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753164AbbHGNgp (ORCPT ); Fri, 7 Aug 2015 09:36:45 -0400 Message-ID: <1438954603.3638.37.camel@pengutronix.de> Subject: Re: [PATCH] regulator: da9063: Add set_voltage_time_sel function From: Philipp Zabel To: Mark Brown Cc: linux-kernel@vger.kernel.org, Liam Girdwood , kernel@pengutronix.de, support.opensource@diasemi.com Date: Fri, 07 Aug 2015 15:36:43 +0200 In-Reply-To: <20150807132919.GF10301@sirena.org.uk> References: <1438879104-13081-1-git-send-email-p.zabel@pengutronix.de> <20150806183322.GF20873@sirena.org.uk> <1438939763.3638.14.camel@pengutronix.de> <20150807123112.GV20873@sirena.org.uk> <1438953696.3638.34.camel@pengutronix.de> <20150807132919.GF10301@sirena.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, den 07.08.2015, 14:29 +0100 schrieb Mark Brown: > On Fri, Aug 07, 2015 at 03:21:36PM +0200, Philipp Zabel wrote: > > Am Freitag, den 07.08.2015, 13:31 +0100 schrieb Mark Brown: > > > > (or ideally split out the updates to the > > > drivers into separate patches). > > > When splitting the patch, the series either won't be bisectable (core > > patch first) or temporarily remove functionality (driver patches first). > > What do you suggest? > > I'd expect to see the core patch first - why would it break bisection? > Having the generic operation explicitly specified should still work just > as well as if the device specifies the generic function explicitly. I had unexported regmap_set_voltage_time_sel. I'll drop that part and split it up as you prefer. regards Philipp