From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932470AbbHJRok (ORCPT ); Mon, 10 Aug 2015 13:44:40 -0400 Received: from seldrel01.sonyericsson.com ([37.139.156.2]:15713 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932271AbbHJRoj (ORCPT ); Mon, 10 Aug 2015 13:44:39 -0400 From: Tim Bird To: , CC: , , , Subject: [PATCH] extcon: add index increment in find_cable_index_by_name Date: Mon, 10 Aug 2015 10:44:35 -0700 Message-ID: <1439228675-27616-1-git-send-email-tim.bird@sonymobile.com> X-Mailer: git-send-email 1.8.2.2 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This fixes a bug introduced by commit 73b6ecdb93e8 ("extcon: Redefine the unique id of supported external connectors without 'enum extcon' type") which introduced an infinite loop in find_cable_index_by_name. That commit converted the scan from a for loop to a while, but did not increment 'i' anywhere in the loop. If the loop index is not incremented, the function never exits. This function can never work correctly without this fix. Signed-off-by: Tim Bird --- drivers/extcon/extcon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index dda1e62..734a9b1 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -138,6 +138,7 @@ static int find_cable_index_by_name(struct extcon_dev *edev, const char *name) id = i; break; } + i++; } if (id == EXTCON_NONE) -- 1.8.2.2