mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: linux-leds@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, cooloney@gmail.com,
	rpurdie@rpsys.net, stsp@users.sourceforge.net,
	Andrew Lunn <andrew@lunn.ch>,
	Jacek Anaszewski <j.anaszewski@samsung.com>
Subject: [PATCH/RFC v5 13/57] leds: 88pm860x: Remove work queue
Date: Tue, 11 Aug 2015 11:37:26 +0200	[thread overview]
Message-ID: <1439285890-27329-14-git-send-email-j.anaszewski@samsung.com> (raw)
In-Reply-To: <1439285890-27329-1-git-send-email-j.anaszewski@samsung.com>

From: Andrew Lunn <andrew@lunn.ch>

Now the core implements the work queue, remove it from the driver.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
---
 drivers/leds/leds-88pm860x.c |   22 ++++++----------------
 1 file changed, 6 insertions(+), 16 deletions(-)

diff --git a/drivers/leds/leds-88pm860x.c b/drivers/leds/leds-88pm860x.c
index 1497a09..a2f7b10 100644
--- a/drivers/leds/leds-88pm860x.c
+++ b/drivers/leds/leds-88pm860x.c
@@ -16,7 +16,6 @@
 #include <linux/i2c.h>
 #include <linux/leds.h>
 #include <linux/slab.h>
-#include <linux/workqueue.h>
 #include <linux/mfd/88pm860x.h>
 #include <linux/module.h>
 
@@ -33,7 +32,6 @@
 struct pm860x_led {
 	struct led_classdev cdev;
 	struct i2c_client *i2c;
-	struct work_struct work;
 	struct pm860x_chip *chip;
 	struct mutex lock;
 	char name[MFD_NAME_SIZE];
@@ -69,17 +67,18 @@ static int led_power_set(struct pm860x_chip *chip, int port, int on)
 	return ret;
 }
 
-static void pm860x_led_work(struct work_struct *work)
+static void pm860x_led_set(struct led_classdev *cdev,
+			   enum led_brightness value)
 {
-
-	struct pm860x_led *led;
+	struct pm860x_led *led = container_of(cdev, struct pm860x_led, cdev);
 	struct pm860x_chip *chip;
 	unsigned char buf[3];
 	int ret;
 
-	led = container_of(work, struct pm860x_led, work);
 	chip = led->chip;
 	mutex_lock(&led->lock);
+	led->brightness = value >> 3;
+
 	if ((led->current_brightness == 0) && led->brightness) {
 		led_power_set(chip, led->port, 1);
 		if (led->iset) {
@@ -114,15 +113,6 @@ static void pm860x_led_work(struct work_struct *work)
 	mutex_unlock(&led->lock);
 }
 
-static void pm860x_led_set(struct led_classdev *cdev,
-			   enum led_brightness value)
-{
-	struct pm860x_led *data = container_of(cdev, struct pm860x_led, cdev);
-
-	data->brightness = value >> 3;
-	schedule_work(&data->work);
-}
-
 #ifdef CONFIG_OF
 static int pm860x_led_dt_init(struct platform_device *pdev,
 			      struct pm860x_led *data)
@@ -213,8 +203,8 @@ static int pm860x_led_probe(struct platform_device *pdev)
 	data->current_brightness = 0;
 	data->cdev.name = data->name;
 	data->cdev.brightness_set = pm860x_led_set;
+	data->cdev.flags = LED_BRIGHTNESS_BLOCKING;
 	mutex_init(&data->lock);
-	INIT_WORK(&data->work, pm860x_led_work);
 
 	ret = led_classdev_register(chip->dev, &data->cdev);
 	if (ret < 0) {
-- 
1.7.9.5


  parent reply	other threads:[~2015-08-11  9:39 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11  9:37 [PATCH/RFC v5 00/57] Remove work queues from LED class drivers Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 01/57] leds: Add brightness_set_nonblocking op Jacek Anaszewski
2015-08-13 14:15   ` Andrew Lunn
2015-08-13 14:23     ` Pavel Machek
2015-08-14  7:57     ` Jacek Anaszewski
2015-08-19 14:03       ` Jacek Anaszewski
2015-08-19 14:09         ` Andrew Lunn
2015-08-19 19:31           ` Pavel Machek
2015-08-11  9:37 ` [PATCH/RFC v5 02/57] leds: Add LED_BRIGHTNESS_BLOCKING flag Jacek Anaszewski
2015-08-13 14:05   ` Andrew Lunn
2015-08-11  9:37 ` [PATCH/RFC v5 03/57] leds: Add led_set_brightness_sync to the public LED subsystem API Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 04/57] leds: Improve asynchronous path of setting brightness Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 05/57] leds: Add an internal led_set_brightness_nosleep function Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 06/57] leds: Improve setting brightness in a non sleeping way Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 07/57] leds: Drivers shouldn't enforce SYNC/ASYNC brightness setting Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 08/57] leds: ktd2692: Remove work queue Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 09/57] leds: aat1290: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 10/57] leds: max77693: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 11/57] Documentation: leds: Add description of brightness_set* ops Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 12/57] leds: tlc591xx: Remove work queue Jacek Anaszewski
2015-08-11  9:37 ` Jacek Anaszewski [this message]
2015-08-11  9:37 ` [PATCH/RFC v5 14/57] leds: adp5520: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 15/57] leds: bd2802: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 16/57] leds: blinkm: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 17/57] leds: lm3533: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 18/57] leds: lm3642: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 19/57] leds: pca9532: Remove work queue for LEDs Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 20/57] leds: lp3944: Remove work queue Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 21/57] leds: lp55xx: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 22/57] leds: lp8788: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 23/57] leds: lp8860: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 24/57] leds: pca955x: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 25/57] leds: pca963x: " Jacek Anaszewski
2015-08-11  9:42   ` Peter Meerwald
2015-08-11 10:00   ` Ricardo Ribalda Delgado
2015-08-11 10:35     ` Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 26/57] leds: wm831x: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 27/57] leds: da903x: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 28/57] leds: da9052: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 29/57] leds: dac124d085: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 30/57] leds: lt3593: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 31/57] leds: max8997: Remove unneeded workqueue include Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 32/57] leds: mc13783: Remove work queue Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 33/57] leds: regulator: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 34/57] leds: wm8350: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 35/57] leds: gpio: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 36/57] leds: pwm: remove " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 37/57] leds: lm355x: Remove " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 38/57] leds: cobalt-raq: Use brightness_set_nonblocking op Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 39/57] leds: bcm6328: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 40/57] leds: bcm6358: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 41/57] leds: syscon: " Jacek Anaszewski
2015-08-11 12:54   ` Linus Walleij
2015-08-11  9:37 ` [PATCH/RFC v5 42/57] leds: ot200: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 43/57] leds: s3c24xx: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 44/57] leds: ss4200: " Jacek Anaszewski
2015-08-11  9:37 ` [PATCH/RFC v5 45/57] leds: versatile: " Jacek Anaszewski
2015-08-11 12:55   ` Linus Walleij
2015-08-11  9:37 ` [PATCH/RFC v5 46/57] leds: wrap: " Jacek Anaszewski
2015-08-11  9:38 ` [PATCH/RFC v5 47/57] leds: net48xx: " Jacek Anaszewski
2015-08-11  9:38 ` [PATCH/RFC v5 48/57] leds: asic3: " Jacek Anaszewski
2015-08-11  9:38 ` [PATCH/RFC v5 49/57] leds: cobalt-qube: " Jacek Anaszewski
2015-08-11  9:38 ` [PATCH/RFC v5 50/57] leds: fsg: " Jacek Anaszewski
2015-08-11  9:38 ` [PATCH/RFC v5 51/57] leds: hp6xx: " Jacek Anaszewski
2015-08-11  9:38 ` [PATCH/RFC v5 52/57] leds: locomo: " Jacek Anaszewski
2015-08-11  9:38 ` [PATCH/RFC v5 53/57] leds: dell: " Jacek Anaszewski
2015-08-11  9:38 ` [PATCH/RFC v5 54/57] leds: rb532: " Jacek Anaszewski
2015-08-11  9:38 ` [PATCH/RFC v5 55/57] leds: sunfire: " Jacek Anaszewski
2015-08-11 17:27   ` David Miller
2015-08-11  9:38 ` [PATCH/RFC v5 56/57] leds: ipaq-micro: Set LED_BRIGHTNESS_BLOCKING flag Jacek Anaszewski
2015-08-11 12:55   ` Linus Walleij
2015-08-11  9:38 ` [PATCH/RFC v5 57/57] leds: clevo-mail: " Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439285890-27329-14-git-send-email-j.anaszewski@samsung.com \
    --to=j.anaszewski@samsung.com \
    --cc=andrew@lunn.ch \
    --cc=cooloney@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    --cc=stsp@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®