From: Shunqian Zheng <zhengsq@rock-chips.com>
To: gregkh@linuxfoundation.org, srinivas.kandagatla@linaro.org,
maxime.ripard@free-electrons.com, heiko@sntech.de,
caesar.wang@rock-chips.com
Cc: mturquette@baylibre.com, sboyd@codeaurora.org,
linux-clk@vger.kernel.org, dianders@chromium.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
xjq@rock-chips.com, ZhengShunQian <zhengsq@rock-chips.com>
Subject: [PATCH v2 2/5] nvmem: fix the out-of-range leak in read/write()
Date: Tue, 11 Aug 2015 18:13:41 +0800 [thread overview]
Message-ID: <1439288024-13359-3-git-send-email-zhengsq@rock-chips.com> (raw)
In-Reply-To: <1439288024-13359-1-git-send-email-zhengsq@rock-chips.com>
From: ZhengShunQian <zhengsq@rock-chips.com>
The position to read/write must be less than max
register size.
Signed-off-by: ZhengShunQian <zhengsq@rock-chips.com>
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
drivers/nvmem/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index d3c6676..f4af8e5 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -67,7 +67,7 @@ static ssize_t bin_attr_nvmem_read(struct file *filp, struct kobject *kobj,
int rc;
/* Stop the user from reading */
- if (pos > nvmem->size)
+ if (pos >= nvmem->size)
return 0;
if (pos + count > nvmem->size)
@@ -92,7 +92,7 @@ static ssize_t bin_attr_nvmem_write(struct file *filp, struct kobject *kobj,
int rc;
/* Stop the user from writing */
- if (pos > nvmem->size)
+ if (pos >= nvmem->size)
return 0;
if (pos + count > nvmem->size)
--
1.9.1
next prev parent reply other threads:[~2015-08-11 10:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 10:13 [PATCH v2 0/5] Add eFuse driver of Rockchip SoC Shunqian Zheng
2015-08-11 10:13 ` [PATCH v2 1/5] clk: rockchip: rk3288: Add the clock id of eFuse Shunqian Zheng
2015-08-12 1:31 ` Stephen Boyd
2015-08-11 10:13 ` Shunqian Zheng [this message]
2015-08-11 10:13 ` [PATCH v2 3/5] nvmem: rockchip-efuse: implement efuse driver Shunqian Zheng
2015-08-11 10:13 ` [PATCH v2 4/5] Documentation: rockchip-efuse: describe the usage of eFuse Shunqian Zheng
2015-08-11 10:13 ` [PATCH v2 5/5] ARM: dts: rockchip: add eFuse config of rk3288 SoC Shunqian Zheng
2015-12-12 19:21 ` [PATCH v2 0/5] Add eFuse driver of Rockchip SoC Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439288024-13359-3-git-send-email-zhengsq@rock-chips.com \
--to=zhengsq@rock-chips.com \
--cc=caesar.wang@rock-chips.com \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=xjq@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®