From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752015AbbHMA3N (ORCPT ); Wed, 12 Aug 2015 20:29:13 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:56559 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751137AbbHMA3L (ORCPT ); Wed, 12 Aug 2015 20:29:11 -0400 X-AuditID: cbfee68d-f79106d00000728c-fb-55cbe4d5cc91 From: Chanwoo Choi To: linux-kernel@vger.kernel.org Cc: cw00.choi@samsung.com, sfr@canb.auug.org.au, u.kleine-koenig@pengutronix.de, rogerq@ti.com Subject: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional API change Date: Thu, 13 Aug 2015 09:29:04 +0900 Message-id: <1439425744-20009-1-git-send-email-cw00.choi@samsung.com> X-Mailer: git-send-email 1.8.5.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBLMWRmVeSWpSXmKPExsWyRsSkUPfqk9OhBq+3SVtc//Kc1eLyrjls Fj2PtCy27r3KbnF74mRGB1aPxhs32Dz6/xp49G1Zxehx/MZ2Jo/Pm+QCWKO4bFJSczLLUov0 7RK4Mj7vmM9e8Im94sfVvUwNjA/Zuhg5OSQETCQavm5khrDFJC7cWw8U5+IQEljBKPHk50Em mKJfE3ZCJZYyStyaA1P1hVHixeJn7CBVbAJaEvtf3AAbKyKgILG59xkriM0skCDx7vcisEnC AjESXRNWg61jEVCVePq1gQXE5hVwlTh8roUdYpuCxLLlM1lBFkgIvGaT+Pt3BitEg4DEt8mH gBo4gBKyEpsOQJ0tKXFwxQ2WCYyCCxgZVjGKphYkFxQnpRcZ6hUn5haX5qXrJefnbmIEBujp f896dzDePmB9iFGAg1GJh3fDo9OhQqyJZcWVuYcYTYE2TGSWEk3OB8ZBXkm8obGZkYWpiamx kbmlmZI4r6LUz2AhgfTEktTs1NSC1KL4otKc1OJDjEwcnFINjDaLtub+y/ihr/LqpsayJLuj r3zmFH7a3CXwcLlYzYYHwaEzWThMlvY9ym9x6nr7eeGS16d8wr8rH/3099ad6f6d27ZMNNL6 JftKleF939yrk3Y7uFTfrVGXznZ+fvecjcqhiqijpZZrK15wrDrjI7+yQvyrxZxDvzde/2HF zpD6fk6v6rzZZxOUWIozEg21mIuKEwEGGLKlSwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplkeLIzCtJLcpLzFFi42I5/e+xgO7VJ6dDDa58ErO4/uU5q8XlXXPY LHoeaVls3XuV3eL2xMmMDqwejTdusHn0/zXw6NuyitHj+I3tTB6fN8kFsEY1MNpkpCampBYp pOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam2iq5+AToumXmAO1WUihLzCkFCgUkFhcr 6dthmhAa4qZrAdMYoesbEgTXY2SABhLWMGZ83jGfveATe8WPq3uZGhgfsnUxcnJICJhI/Jqw E8oWk7hwbz2QzcUhJLCUUeLWHBjnC6PEi8XP2EGq2AS0JPa/uAHWISKgILG59xkriM0skCDx 7vciJhBbWCBGomvCamYQm0VAVeLp1wYWEJtXwFXi8LkWdohtChLLls9kncDIvYCRYRWjRGpB ckFxUnquUV5quV5xYm5xaV66XnJ+7iZGcBQ8k97BeHiX+yFGAQ5GJR5eg4mnQoVYE8uKK3MP MUpwMCuJ8EruOR0qxJuSWFmVWpQfX1Sak1p8iNEU6ICJzFKiyfnACM0riTc0NjEzsjQyN7Qw MjZXEufVN9kUKiSQnliSmp2aWpBaBNPHxMEp1cC4ZvJeMYNvhftbVsnkx+YzHuR8ddhPs8bp jIFER1go5/KTxikCFqtND7te7NP/ECHr+/OgdKkog4Njwp6QQo89jC905W+kdyXw1y5kOOul uSn2xPL9Adau9X5LMu+taokw23qUaaqspjjTh6YDgQzF2yRfa/MsyLfcefjU4QO95nlfDJW1 mJVYijMSDbWYi4oTAej08OmYAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions") changes the prototype of devm_gpiod_get_optional() API which should include the falgs mandatory. Reported-by: Stephen Rothwell Signed-off-by: Chanwoo Choi --- drivers/extcon/extcon-palmas.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c index 662e91778cb0..308928d44ead 100644 --- a/drivers/extcon/extcon-palmas.c +++ b/drivers/extcon/extcon-palmas.c @@ -208,7 +208,8 @@ static int palmas_usb_probe(struct platform_device *pdev) palmas_usb->wakeup = pdata->wakeup; } - palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id"); + palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id", + GPIOD_IN); if (IS_ERR(palmas_usb->id_gpiod)) { dev_err(&pdev->dev, "failed to get id gpio\n"); return PTR_ERR(palmas_usb->id_gpiod); -- 1.8.5.5