From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752588AbbHMNgP (ORCPT ); Thu, 13 Aug 2015 09:36:15 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:34968 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751590AbbHMNgO (ORCPT ); Thu, 13 Aug 2015 09:36:14 -0400 From: Sudip Mukherjee To: Miguel Ojeda Sandonis , gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, fengguang.wu@intel.com, Sudip Mukherjee Subject: [PATCH] auxdisplay: ks0108: initialize local parport variable Date: Thu, 13 Aug 2015 19:06:05 +0530 Message-Id: <1439472965-29153-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The local variable ks0108_parport is used by other functions to write to the parallel port. We missed initializing it when we converted the driver to use new Parallel Port codes. Fixes: 4edd70c133f3 ("auxdisplay: ks0108: use new parport device model") Reported-by: Fengguang Wu Signed-off-by: Sudip Mukherjee --- Tested on kvm with the script provided by Fengguang Wu to reproduce the error. drivers/auxdisplay/ks0108.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/auxdisplay/ks0108.c b/drivers/auxdisplay/ks0108.c index 4c471bd..816de9e 100644 --- a/drivers/auxdisplay/ks0108.c +++ b/drivers/auxdisplay/ks0108.c @@ -146,6 +146,7 @@ static void ks0108_parport_attach(struct parport *port) goto err_unreg_device; } + ks0108_parport = port; ks0108_inited = 1; return; @@ -167,6 +168,7 @@ static void ks0108_parport_detach(struct parport *port) parport_release(ks0108_pardevice); parport_unregister_device(ks0108_pardevice); ks0108_pardevice = NULL; + ks0108_parport = NULL; } /* -- 1.9.1