From: Grygorii Strashko <grygorii.strashko@ti.com>
To: <tglx@linutronix.de>, <tony@atomide.com>, <marc.zyngier@arm.com>
Cc: <linux@arm.linux.org.uk>, <nsekhar@ti.com>,
<jason@lakedaemon.net>, <balbi@ti.com>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Jiang Liu <jiang.liu@linux.intel.com>
Subject: [PATCH v3 1/6] genirq: fix irq_chip_retrigger_hierarchy
Date: Fri, 14 Aug 2015 15:20:25 +0300 [thread overview]
Message-ID: <1439554830-19502-2-git-send-email-grygorii.strashko@ti.com> (raw)
In-Reply-To: <1439554830-19502-1-git-send-email-grygorii.strashko@ti.com>
Now irq_chip_retrigger_hierarchy() returns -ENOSYS if it
was not able to find at least one .irq_retrigger() callback
implemented in IRQ domain hierarchy. As result, IRQ
re-triggering is not working now on ARM (TI OMAP) where
ARM GIC is not implemented this callback.
The .irq_retrigger() is optional (see check_irq_resend())
and there are no reasons to fail if it was not found, hence
lets return 0 in this case.
In case of TI OMAP DRA7 the following IRQ hierarchy is defined:
ARM GIC <- OMAP wakeupgen <- TI CBAR
Failure is reproduced during resume from suspend to RAM:
- wakeup by IRQx
- suspend_enter
+ arch_suspend_enable_irqs
+ handle_fasteoi_irq
+ irq_may_run
+ irq_pm_check_wakeup
+ irq_disable(IRQx)
+ dpm_resume_noirq()
+ resume_device_irqs
+ resume_irqs
+ resume_irq
+ __enable_irq <== IRQx is not re-triggered
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Jiang Liu <jiang.liu@linux.intel.com>
Fixes: 85f08c17de26 ('genirq: Introduce helper functions...')
Reviewed-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
kernel/irq/chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 27f4332..6de638b 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -997,7 +997,7 @@ int irq_chip_retrigger_hierarchy(struct irq_data *data)
if (data->chip && data->chip->irq_retrigger)
return data->chip->irq_retrigger(data);
- return -ENOSYS;
+ return 0;
}
/**
--
2.5.0
next prev parent reply other threads:[~2015-08-14 12:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 12:20 [PATCH v3 0/6] genirq: irqdomain_hierarchy: fixes Grygorii Strashko
2015-08-14 12:20 ` Grygorii Strashko [this message]
2015-08-17 3:28 ` [PATCH v3 1/6] genirq: fix irq_chip_retrigger_hierarchy Jiang Liu
2015-08-19 23:21 ` [tip:irq/urgent] genirq: Don' t return ENOSYS in irq_chip_retrigger_hierarchy tip-bot for Grygorii Strashko
2015-08-14 12:20 ` [PATCH v3 2/6] genirq: introduce irq_chip_set_type_parent() helper Grygorii Strashko
2015-08-19 23:21 ` [tip:irq/urgent] genirq: Introduce " tip-bot for Grygorii Strashko
2015-08-14 12:20 ` [PATCH v3 3/6] irqchip: crossbar: fix arm gic irq type configuration Grygorii Strashko
2015-08-19 23:22 ` [tip:irq/urgent] irqchip/crossbar: Restore the irq_set_type() mechanism tip-bot for Grygorii Strashko
2015-08-14 12:20 ` [PATCH v3 4/6] ARM: OMAP: wakeupgen: fix arm gic irq type configuration Grygorii Strashko
2015-08-19 23:22 ` [tip:irq/urgent] ARM: OMAP: wakeupgen: Restore the irq_set_type() mechanism tip-bot for Grygorii Strashko
2015-08-14 12:20 ` [PATCH v3 5/6] irqchip: crossbar: fix irq masking at suspend Grygorii Strashko
2015-08-19 23:22 ` [tip:irq/urgent] irqchip/crossbar: Restore the mask on suspend behaviour tip-bot for Grygorii Strashko
2015-08-14 12:20 ` [PATCH v3 6/6] irqchip: crossbar: fix set_wake functionality Grygorii Strashko
2015-08-19 23:23 ` [tip:irq/urgent] irqchip/crossbar: Restore " tip-bot for Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439554830-19502-2-git-send-email-grygorii.strashko@ti.com \
--to=grygorii.strashko@ti.com \
--cc=balbi@ti.com \
--cc=jason@lakedaemon.net \
--cc=jiang.liu@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=nsekhar@ti.com \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome