From: Mike Rapoport <mike.rapoport@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Mike Rapoport" <mike.rapoport@gmail.com>,
"Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
"Noralf Trønnes" <noralf@tronnes.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 4/5] staging: fbtft: fb_ssd1351: define backlight_ops statically
Date: Sun, 16 Aug 2015 23:36:36 +0300 [thread overview]
Message-ID: <1439757397-2304-5-git-send-email-mike.rapoport@gmail.com> (raw)
In-Reply-To: <1439757397-2304-1-git-send-email-mike.rapoport@gmail.com>
instead of devm_kzalloc'ing them
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
---
drivers/staging/fbtft/fb_ssd1351.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ssd1351.c b/drivers/staging/fbtft/fb_ssd1351.c
index 9bcd7a0..dff5809 100644
--- a/drivers/staging/fbtft/fb_ssd1351.c
+++ b/drivers/staging/fbtft/fb_ssd1351.c
@@ -208,25 +208,22 @@ static int update_onboard_backlight(struct backlight_device *bd)
return 0;
}
+static const struct backlight_ops bl_ops = {
+ .update_status = update_onboard_backlight,
+};
+
static void register_onboard_backlight(struct fbtft_par *par)
{
struct backlight_device *bd;
struct backlight_properties bl_props = { 0, };
- struct backlight_ops *bl_ops;
fbtft_par_dbg(DEBUG_BACKLIGHT, par, "%s()\n", __func__);
- bl_ops = devm_kzalloc(par->info->device, sizeof(struct backlight_ops),
- GFP_KERNEL);
- if (!bl_ops)
- return;
-
- bl_ops->update_status = update_onboard_backlight;
bl_props.type = BACKLIGHT_RAW;
bl_props.power = FB_BLANK_POWERDOWN;
bd = backlight_device_register(dev_driver_string(par->info->device),
- par->info->device, par, bl_ops, &bl_props);
+ par->info->device, par, &bl_ops, &bl_props);
if (IS_ERR(bd)) {
dev_err(par->info->device,
"cannot register backlight device (%ld)\n",
--
1.8.3.1
next prev parent reply other threads:[~2015-08-16 20:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-16 20:36 [PATCH 0/5] staging: fbtft: some checpatch.pl cleanups Mike Rapoport
2015-08-16 20:36 ` [PATCH 1/5] staging: fbtft: remove unused bl_ops from fbtft_unregister_backlight Mike Rapoport
2015-09-03 1:08 ` Greg Kroah-Hartman
2015-08-16 20:36 ` [PATCH 2/5] staging: fbtft: fbtft-core: define backlight_ops statically Mike Rapoport
2015-08-16 20:36 ` [PATCH 3/5] staging: fbtft: fbtft_request_gpios: reduce nesting Mike Rapoport
2015-08-16 20:36 ` Mike Rapoport [this message]
2015-08-16 20:36 ` [PATCH 5/5] staging: fbtft: fb_watterott: define backlight_ops statically Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439757397-2304-5-git-send-email-mike.rapoport@gmail.com \
--to=mike.rapoport@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome