From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753173AbbHPUhV (ORCPT ); Sun, 16 Aug 2015 16:37:21 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:34780 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751874AbbHPUhS (ORCPT ); Sun, 16 Aug 2015 16:37:18 -0400 From: Mike Rapoport To: Greg Kroah-Hartman Cc: Mike Rapoport , Thomas Petazzoni , =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= , LKML Subject: [PATCH 5/5] staging: fbtft: fb_watterott: define backlight_ops statically Date: Sun, 16 Aug 2015 23:36:37 +0300 Message-Id: <1439757397-2304-6-git-send-email-mike.rapoport@gmail.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1439757397-2304-1-git-send-email-mike.rapoport@gmail.com> References: <1439757397-2304-1-git-send-email-mike.rapoport@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org instead of devm_kzalloc'ing them Signed-off-by: Mike Rapoport --- drivers/staging/fbtft/fb_watterott.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/staging/fbtft/fb_watterott.c b/drivers/staging/fbtft/fb_watterott.c index 88fb2c0..e8ebe2e 100644 --- a/drivers/staging/fbtft/fb_watterott.c +++ b/drivers/staging/fbtft/fb_watterott.c @@ -257,31 +257,24 @@ static int backlight_chip_update_status(struct backlight_device *bd) return 0; } +static const struct backlight_ops bl_ops = { + .update_status = backlight_chip_update_status, +}; + static void register_chip_backlight(struct fbtft_par *par) { struct backlight_device *bd; struct backlight_properties bl_props = { 0, }; - struct backlight_ops *bl_ops; fbtft_par_dbg(DEBUG_BACKLIGHT, par, "%s()\n", __func__); - bl_ops = devm_kzalloc(par->info->device, sizeof(struct backlight_ops), - GFP_KERNEL); - if (!bl_ops) { - dev_err(par->info->device, - "%s: could not allocate memory for backlight operations.\n", - __func__); - return; - } - - bl_ops->update_status = backlight_chip_update_status; bl_props.type = BACKLIGHT_RAW; bl_props.power = FB_BLANK_POWERDOWN; bl_props.max_brightness = 100; bl_props.brightness = DEFAULT_BRIGHTNESS; bd = backlight_device_register(dev_driver_string(par->info->device), - par->info->device, par, bl_ops, &bl_props); + par->info->device, par, &bl_ops, &bl_props); if (IS_ERR(bd)) { dev_err(par->info->device, "cannot register backlight device (%ld)\n", -- 1.8.3.1