From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755318AbbHQNYF (ORCPT ); Mon, 17 Aug 2015 09:24:05 -0400 Received: from mga02.intel.com ([134.134.136.20]:54311 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754608AbbHQNYD (ORCPT ); Mon, 17 Aug 2015 09:24:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,695,1432623600"; d="scan'208";a="785288732" From: "Han, Huaitong" To: "alexander.shishkin@linux.intel.com" CC: "linux-kernel@vger.kernel.org" , "a.p.zijlstra@chello.nl" , "mingo@redhat.com" , "acme@kernel.org" Subject: Re: [PATCH] RDMSR before test_cpu_capacity brings about KVM warning Thread-Topic: [PATCH] RDMSR before test_cpu_capacity brings about KVM warning Thread-Index: AQHQ1nk8gorUTXhKtE6MtvXsBaKouZ4Plp4AgAAWGYA= Date: Mon, 17 Aug 2015 13:23:22 +0000 Message-ID: <1439817801.5209.8.camel@huaitong-MOBL.ccr.corp.intel.com> References: <1439546857-12791-1-git-send-email-huaitong.han@intel.com> <87bne6jf3z.fsf@ashishki-desk.ger.corp.intel.com> In-Reply-To: <87bne6jf3z.fsf@ashishki-desk.ger.corp.intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.29.227] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t7HDOA2h010170 On Mon, 2015-08-17 at 15:04 +0300, Alexander Shishkin wrote: > Huaitong Han writes: > > > rdmsrl_safe does not lead to #GP in native kernel although CPU > > does not support INTEL_PT, but if KVM does not support INTEL_PT, > > the codes cannot understand MSR_IA32_RTIT_CTL, and the warning > > is produced. > > "the codes"? KVM codes. Current KVM does not support Intel_PT. But guest kernel may readmsr MSR_IA32_RTIT_CTL that KVM cannot understand. Details from https://bugzilla.kernel.org/show_bug.cgi?id=102651 > > > If KVM does not support INTEL_PT, its guest CPUID also does not. > > So test_cpu_cap is added before RDMSR, and it is more in line with > > the code style. > > It does make more sense like this, but please improve this commit > message. And don't forget to include Peter in the loop. I will update the commit message. > > FWIW, > > Reviewed-by: Alexander Shishkin > > Regards, > -- > Alex {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I