mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kan.liang@intel.com
To: acme@kernel.org
Cc: a.p.zijlstra@chello.nl, mingo@redhat.com, jolsa@kernel.org,
	namhyung@kernel.org, ak@linux.intel.com, eranian@google.com,
	linux-kernel@vger.kernel.org, Kan Liang <kan.liang@intel.com>
Subject: [PATCH RFC 09/10] perf,tools: don't validate non-sample event
Date: Tue, 18 Aug 2015 05:25:45 -0400	[thread overview]
Message-ID: <1439889946-28986-10-git-send-email-kan.liang@intel.com> (raw)
In-Reply-To: <1439889946-28986-1-git-send-email-kan.liang@intel.com>

From: Kan Liang <kan.liang@intel.com>

Stat event (:N) doesn't do sampling. So perf tool should not validate
its sample_type, read_format and sample_id_all.

Signed-off-by: Kan Liang <kan.liang@intel.com>
---
 tools/perf/util/evlist.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index ca7bf8d..fc2da23 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -1249,6 +1249,8 @@ bool perf_evlist__valid_sample_type(struct perf_evlist *evlist)
 		return false;
 
 	evlist__for_each(evlist, pos) {
+		if (!pos->attr.sample_type)
+			continue;
 		if (pos->id_pos != evlist->id_pos ||
 		    pos->is_pos != evlist->is_pos)
 			return false;
@@ -1293,6 +1295,8 @@ bool perf_evlist__valid_read_format(struct perf_evlist *evlist)
 	u64 sample_type = first->attr.sample_type;
 
 	evlist__for_each(evlist, pos) {
+		if (!pos->attr.sample_type)
+			continue;
 		if (read_format != pos->attr.read_format)
 			return false;
 	}
@@ -1350,6 +1354,8 @@ bool perf_evlist__valid_sample_id_all(struct perf_evlist *evlist)
 	struct perf_evsel *first = perf_evlist__first(evlist), *pos = first;
 
 	evlist__for_each_continue(evlist, pos) {
+		if (!pos->attr.sample_type)
+			continue;
 		if (first->attr.sample_id_all != pos->attr.sample_id_all)
 			return false;
 	}
-- 
1.8.3.1


  parent reply	other threads:[~2015-08-18 16:42 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-18  9:25 [PATCH RFC 00/10] stat read during perf sampling kan.liang
2015-08-18  9:25 ` [PATCH RFC 01/10] perf,tools: open event on evsel cpus and threads kan.liang
2015-08-20  8:57   ` Jiri Olsa
2015-08-20 17:24     ` Liang, Kan
2015-08-21  7:43       ` Jiri Olsa
2015-08-21 13:24         ` Liang, Kan
2015-08-18  9:25 ` [PATCH RFC 02/10] perf,tools: Support new sort type --socket kan.liang
2015-08-20  9:09   ` Jiri Olsa
2015-08-21 20:25     ` Liang, Kan
2015-08-23 22:00       ` Jiri Olsa
2015-08-24 14:22         ` Liang, Kan
2015-08-24 14:27           ` Jiri Olsa
2015-08-24 16:47             ` Liang, Kan
2015-08-24 19:30               ` Jiri Olsa
2015-08-27 18:24                 ` Jiri Olsa
2015-08-27 18:29                   ` Liang, Kan
2015-08-18  9:25 ` [PATCH RFC 03/10] perf,tools: support option --socket kan.liang
2015-08-18 17:36   ` Stephane Eranian
2015-08-20  9:30   ` Jiri Olsa
2015-08-18  9:25 ` [PATCH RFC 04/10] perf,tools: Add 'N' event/group modifier kan.liang
2015-08-18  9:25 ` [PATCH RFC 05/10] perf,tools: Enable statistic read for perf record kan.liang
2015-08-20  9:39   ` Jiri Olsa
2015-08-20  9:41   ` Jiri Olsa
2015-08-18  9:25 ` [PATCH RFC 06/10] perf,tools: New RECORD type PERF_RECORD_STAT_READ kan.liang
2015-08-20  9:49   ` Jiri Olsa
2015-08-18  9:25 ` [PATCH RFC 07/10] perf,tools: record counter statistics during sampling kan.liang
2015-08-18  9:25 ` [PATCH RFC 08/10] perf,tools: option to set stat read interval kan.liang
2015-08-18  9:25 ` kan.liang [this message]
2015-08-18  9:25 ` [PATCH RFC 10/10] perf,tools: Show STAT_READ in perf report kan.liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439889946-28986-10-git-send-email-kan.liang@intel.com \
    --to=kan.liang@intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=eranian@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome