From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753390AbbHRPSp (ORCPT ); Tue, 18 Aug 2015 11:18:45 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:33664 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752655AbbHRPSm (ORCPT ); Tue, 18 Aug 2015 11:18:42 -0400 From: Sudip Mukherjee To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Sudip Mukherjee Subject: [PATCH 2/9] staging: most: bool comparison style Date: Tue, 18 Aug 2015 20:48:21 +0530 Message-Id: <1439911108-20765-2-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1439911108-20765-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1439911108-20765-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mentioning true or false in the if comparison is error prone and also not according to the coding style. Signed-off-by: Sudip Mukherjee --- drivers/staging/most/aim-cdev/cdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/most/aim-cdev/cdev.c b/drivers/staging/most/aim-cdev/cdev.c index 7b637f3..e5853d0 100644 --- a/drivers/staging/most/aim-cdev/cdev.c +++ b/drivers/staging/most/aim-cdev/cdev.c @@ -133,7 +133,7 @@ static int aim_close(struct inode *inode, struct file *filp) while (0 != kfifo_out((struct kfifo *)&channel->fifo, &mbo, 1)) most_put_mbo(mbo); - if (channel->keep_mbo == true) + if (channel->keep_mbo) most_put_mbo(channel->stacked_mbo); ret = most_stop_channel(channel->iface, channel->channel_id); atomic_dec(&channel->access_ref); @@ -224,7 +224,7 @@ aim_read(struct file *filp, char __user *buf, size_t count, loff_t *offset) struct mbo *mbo; struct aim_channel *channel = filp->private_data; - if (channel->keep_mbo == true) { + if (channel->keep_mbo) { mbo = channel->stacked_mbo; channel->keep_mbo = false; goto start_copy; @@ -259,7 +259,7 @@ start_copy: retval = not_copied ? proc_len - not_copied : proc_len; - if (channel->keep_mbo == true) { + if (channel->keep_mbo) { channel->mbo_offs = retval; channel->stacked_mbo = mbo; } else { -- 1.9.1