From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH 7/9] staging: most: use NULL pointer
Date: Tue, 18 Aug 2015 20:48:26 +0530 [thread overview]
Message-ID: <1439911108-20765-7-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1439911108-20765-1-git-send-email-sudipm.mukherjee@gmail.com>
sparse was complaining that an integer is used as NULL pointer. Fix it
by using NULL.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/staging/most/hdm-dim2/dim2_hdm.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/most/hdm-dim2/dim2_hdm.c b/drivers/staging/most/hdm-dim2/dim2_hdm.c
index 1ba694b..5b0a588 100644
--- a/drivers/staging/most/hdm-dim2/dim2_hdm.c
+++ b/drivers/staging/most/hdm-dim2/dim2_hdm.c
@@ -238,7 +238,7 @@ static int try_start_dim_transfer(struct hdm_channel *hdm_ch)
unsigned long flags;
struct dim_ch_state_t st;
- BUG_ON(hdm_ch == 0);
+ BUG_ON(!hdm_ch);
BUG_ON(!hdm_ch->is_initialized);
spin_lock_irqsave(&dim_lock, flags);
@@ -336,7 +336,7 @@ static void service_done_flag(struct dim2_hdm *dev, int ch_idx)
unsigned long flags;
u8 *data;
- BUG_ON(hdm_ch == 0);
+ BUG_ON(!hdm_ch);
BUG_ON(!hdm_ch->is_initialized);
spin_lock_irqsave(&dim_lock, flags);
@@ -409,7 +409,7 @@ static struct dim_channel **get_active_channels(struct dim2_hdm *dev,
if (dev->hch[ch_idx].is_initialized)
buffer[idx++] = &dev->hch[ch_idx].ch;
}
- buffer[idx++] = 0;
+ buffer[idx++] = NULL;
return buffer;
}
@@ -905,7 +905,7 @@ static int dim2_remove(struct platform_device *pdev)
* break link to local platform_device_id struct
* to prevent crash by unload platform device module
*/
- pdev->id_entry = 0;
+ pdev->id_entry = NULL;
return 0;
}
--
1.9.1
next prev parent reply other threads:[~2015-08-18 15:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 15:18 [PATCH 1/9] staging: most: NULL comparison style Sudip Mukherjee
2015-08-18 15:18 ` [PATCH 2/9] staging: most: bool " Sudip Mukherjee
2015-08-18 15:18 ` [PATCH 3/9] staging: most: remove multiple blank line Sudip Mukherjee
2015-08-18 15:18 ` [PATCH 4/9] staging: most: out of memory error Sudip Mukherjee
2015-08-18 15:18 ` [PATCH 5/9] staging: most: remove unused functions Sudip Mukherjee
2015-08-18 15:18 ` [PATCH 6/9] staging: most: make functions static Sudip Mukherjee
2015-08-18 15:18 ` Sudip Mukherjee [this message]
2015-08-18 15:18 ` [PATCH 8/9] staging: most: remove unused variable Sudip Mukherjee
2015-08-18 15:18 ` [PATCH 9/9] staging: most: fix Makefile Sudip Mukherjee
2015-08-18 16:31 ` [PATCH 1/9] staging: most: NULL comparison style Fabio Estevam
2015-08-19 10:00 ` Sudip Mukherjee
2015-08-19 14:51 ` Frans Klaver
2015-08-24 13:49 ` [PATCH v2] " Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439911108-20765-7-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®