From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Gwendal Grignou <gwendal@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Wolfram Sang <wsa@the-dreams.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Olof Johansson <olof@lixom.net>,
Javier Martinez Canillas <javier@osg.samsung.com>,
linux-i2c@vger.kernel.org, linux-input@vger.kernel.org
Subject: [PATCH 0/6] ChromeOS EC Kconfig cleanups
Date: Wed, 19 Aug 2015 13:19:52 +0200 [thread overview]
Message-ID: <1439983198-4696-1-git-send-email-javier@osg.samsung.com> (raw)
Hello,
This patch series attemp to fix the issues that exist with the ChromeOS
EC drivers Kconfig symbols. These are:
1) The MFD_CROS_EC config symbol select CROS_EC_PROTO and CHROME_PLATFORMS
which caused a Kconfig unmet direct dependencies warning.
2) Mix of select and depends on for the CROS_EC_PROTO config symbol which
may lead to circular Kconfig dependencies.
The first issue was because CHROME_PLATFORMS depend on X86 || ARM and the
MFD_CROS_EC didn't have this dependency. I thought the correct solution
was to remove the dependency for CHROME_PLATFORMS since in theory there
could be Chromebooks for other architectures.
That was made in commit d12bbcd3ea44 ("platform/chrome: Don't make
CHROME_PLATFORMS depends on X86 || ARM") but Geert nacked that and told me
the correct fix was the opposite, to add the dependencies to the driver
and possibly extend it with || COMPILE_TEST to have more build coverage.
So patch 1/5 do this and patch 2/5 reverts the mentioned commit and also
add || COMPILE_TEST to CHROME_PLATFORMS.
Patches 3/5 to 5/5 fix 2) by not making the drivers depend on CROS_EC_PROTO
since these should really depend on MFD_CROS_EC. And since MFD_CROSEC select
CROS_EC_PROTO already, that dependency is met as well.
Only patches 1/5 and 2/5 have to be applied in the same order and picked
through a single tree to avoid the Kconfig warning to appear again. The
other patches are independent and can go through the other subsystem trees.
Thanks a lot to Geert and Bartolomiej for the feedback and suggestions.
Best regards,
Javier
Javier Martinez Canillas (6):
mfd: Add MFD_CROS_EC dependencies
Revert "platform/chrome: Don't make CHROME_PLATFORMS depends on X86 ||
ARM"
platform/chrome: Make depends on MFD_CROS_EC instead CROS_EC_PROTO
mfd: cros_ec: Remove CROS_EC_PROTO dependency for SPI and I2C drivers
i2c: Replace I2C_CROS_EC_TUNNEL dependency
Input: Replace KEYBOARD_CROS_EC dependency
drivers/i2c/busses/Kconfig | 2 +-
drivers/input/keyboard/Kconfig | 2 +-
drivers/mfd/Kconfig | 5 +++--
drivers/platform/chrome/Kconfig | 5 +++--
4 files changed, 8 insertions(+), 6 deletions(-)
--
2.4.3
next reply other threads:[~2015-08-19 11:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 11:19 Javier Martinez Canillas [this message]
2015-08-19 11:19 ` [PATCH 1/6] mfd: Add MFD_CROS_EC dependencies Javier Martinez Canillas
2015-08-19 13:00 ` Lee Jones
2015-08-19 11:19 ` [PATCH 2/6] Revert "platform/chrome: Don't make CHROME_PLATFORMS depends on X86 || ARM" Javier Martinez Canillas
2015-08-21 17:03 ` Olof Johansson
2015-08-19 11:19 ` [PATCH 3/6] platform/chrome: Make depends on MFD_CROS_EC instead CROS_EC_PROTO Javier Martinez Canillas
2015-08-21 17:03 ` Olof Johansson
2015-08-19 11:19 ` [PATCH 4/6] mfd: cros_ec: Remove CROS_EC_PROTO dependency for SPI and I2C drivers Javier Martinez Canillas
2015-08-19 12:59 ` Lee Jones
2015-08-19 11:19 ` [PATCH 5/6] i2c: Replace I2C_CROS_EC_TUNNEL dependency Javier Martinez Canillas
2015-08-24 12:18 ` Wolfram Sang
2015-08-19 11:19 ` [PATCH 6/6] Input: Replace KEYBOARD_CROS_EC dependency Javier Martinez Canillas
2015-08-19 21:26 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439983198-4696-1-git-send-email-javier@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gwendal@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®