From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754090AbbHSOcd (ORCPT ); Wed, 19 Aug 2015 10:32:33 -0400 Received: from mga09.intel.com ([134.134.136.24]:53817 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753524AbbHSOcS (ORCPT ); Wed, 19 Aug 2015 10:32:18 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,710,1432623600"; d="scan'208";a="544778981" From: Adrian Hunter To: Arnaldo Carvalho de Melo , Arnaldo Carvalho de Melo , Jiri Olsa , Jiri Olsa Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, mingo@kernel.org Subject: [PATCH 3/3] perf tools: Fix buildid processing Date: Wed, 19 Aug 2015 17:29:21 +0300 Message-Id: <1439994561-27436-4-git-send-email-adrian.hunter@intel.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1439994561-27436-1-git-send-email-adrian.hunter@intel.com> References: <1439994561-27436-1-git-send-email-adrian.hunter@intel.com> Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After recording, 'perf record' post-processes the data to determine which buildids are needed. That processing must process the data in time order, if possible, because otherwise dependent events, like forks and mmaps, will not make sense. Signed-off-by: Adrian Hunter --- tools/perf/builtin-record.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index de165a1b9240..f36b88938499 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -500,6 +500,15 @@ static int __cmd_record(struct record *rec, int argc, const char **argv) return -1; } + /* + * Normally perf_session__new would do this, but it doesn't have the + * evlist. + */ + if (rec->tool.ordered_events && !perf_evlist__sample_id_all(rec->evlist)) { + dump_printf("WARNING: No sample_id_all support, falling back to unordered processing\n"); + rec->tool.ordered_events = false; + } + fd = perf_data_file__fd(file); rec->session = session; @@ -965,9 +974,11 @@ static struct record record = { .tool = { .sample = process_sample_event, .fork = perf_event__process_fork, + .exit = perf_event__process_exit, .comm = perf_event__process_comm, .mmap = perf_event__process_mmap, .mmap2 = perf_event__process_mmap2, + .ordered_events = true, }, }; -- 1.9.1