mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
	devel@driverdev.osuosl.org,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-media@vger.kernel.org
Subject: [PATCH 1/4] [media] staging: omap4iss: get entity ID using media_entity_id()
Date: Wed, 19 Aug 2015 17:35:19 +0200	[thread overview]
Message-ID: <1439998526-12832-2-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1439998526-12832-1-git-send-email-javier@osg.samsung.com>

The struct media_entity does not have an .id field anymore since
now the entity ID is stored in the embedded struct media_gobj.

This caused the omap4iss driver fail to build. Fix by using the
media_entity_id() macro to obtain the entity ID.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/staging/media/omap4iss/iss.c       | 2 +-
 drivers/staging/media/omap4iss/iss_video.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
index f32ab7b98ae2..7226553ceb2f 100644
--- a/drivers/staging/media/omap4iss/iss.c
+++ b/drivers/staging/media/omap4iss/iss.c
@@ -607,7 +607,7 @@ static int iss_pipeline_disable(struct iss_pipeline *pipe,
 			 * crashed. Mark it as such, the ISS will be reset when
 			 * applications will release it.
 			 */
-			iss->crashed |= 1U << subdev->entity.id;
+			iss->crashed |= 1U << media_entity_id(&subdev->entity);
 			failure = -ETIMEDOUT;
 		}
 	}
diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/omap4iss/iss_video.c
index bae67742706f..25e9e7a6b99d 100644
--- a/drivers/staging/media/omap4iss/iss_video.c
+++ b/drivers/staging/media/omap4iss/iss_video.c
@@ -784,7 +784,7 @@ iss_video_streamon(struct file *file, void *fh, enum v4l2_buf_type type)
 	entity = &video->video.entity;
 	media_entity_graph_walk_start(&graph, entity);
 	while ((entity = media_entity_graph_walk_next(&graph)))
-		pipe->entities |= 1 << entity->id;
+		pipe->entities |= 1 << media_entity_id(entity);
 
 	/* Verify that the currently configured format matches the output of
 	 * the connected subdev.
-- 
2.4.3


  reply	other threads:[~2015-08-19 15:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-19 15:35 [PATCH 0/4] [media] Media entity cleanups and build fixes Javier Martinez Canillas
2015-08-19 15:35 ` Javier Martinez Canillas [this message]
2015-08-20 18:37   ` [PATCH 1/4] [media] staging: omap4iss: get entity ID using media_entity_id() Laurent Pinchart
2015-08-21  0:14     ` Javier Martinez Canillas
2015-08-21  0:15       ` Laurent Pinchart
2015-08-21  0:31         ` Javier Martinez Canillas
2015-08-21  7:49         ` Hans Verkuil
2015-08-19 15:35 ` [PATCH 2/4] [media] omap3isp: " Javier Martinez Canillas
2015-08-19 15:35 ` [PATCH 3/4] [media] media: use entity.graph_obj.mdev instead of .parent Javier Martinez Canillas
2015-08-20 12:43   ` Hans Verkuil
2015-08-19 15:35 ` [PATCH 4/4] [media] media: remove media entity .parent field Javier Martinez Canillas
2015-08-20 12:43   ` Hans Verkuil
2015-08-19 16:58 ` [PATCH 0/4] [media] Media entity cleanups and build fixes Mauro Carvalho Chehab
2015-08-20 12:41 ` Hans Verkuil
2015-08-20 12:50   ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439998526-12832-2-git-send-email-javier@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®