From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DAD1376497 for ; Mon, 15 Jun 2026 18:33:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781548395; cv=none; b=GUZCR1LaaKrQnTEwjq31/QyNj6edpN2x6sK+bIGrQQgNTtTG0PUySvXXmIQKwt7zIz9lcfzL87ZEuyYopJ2Fm9CDi3MqLSfSDFupQ19e7cXCI5kdJV913JeGJzCPZlBH77Ns8vIKv4AsOt/SvI+lxlgENW6xnY0O2LULPuuTG7c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781548395; c=relaxed/simple; bh=aG2MM7M6ZiH/Mja4fpN6KLtmDjAdhHl4TpdMfnbqBtM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y5aQNjKupFNAQ8u3tQq+PPa4ACH0r4i6LPRiQ4zJds/CvbbO5hfjW2bj9u/bWat3tv/CgVhwrtcc93Y7NwP+ZM0Z/8AkwD/X1sER6Djh9FqFJg+U2DG4AEAd3HjZtCr58fM84ikAcKlNhxqgFXP0VmyEIK8GyM1pbfvnrOcCskA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Hh3lb+Qx; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Hh3lb+Qx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B6CC1F000E9; Mon, 15 Jun 2026 18:33:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781548394; bh=2dHq6clDPMp2c2+59ld9AwPZ9KlPayZOdC9fV263ZTg=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=Hh3lb+QxA3aZVgYqfwHjsJCtWHjLDq/fZxrGlneDMPi+3ghgncfcKMyZ4XXXjThrb vsaJLYp5sK5n/s//K6x+z8lEiIMC2Odxg0TCF6VrxafbdLJt7Sj3jUWf18LMODMo+g ojEO09cBaiNpaZHcHm5RLZLd+sSTLpgKl7dk+g9qZZRK5gCacLvXbCT+4v4GHPJ18N ZYmv7Mmbf8PJvBzqt8jMr7/+BG6tLiTy8ZzrKZsJsQqRoQnLSrcKbIuliXk1aa91xs ubONrL8u9dZWeBmTnSwzdj298BrG6IkwEnlZJ0ItBOlD9z7l4Dnksm/LU5AXE7RKot I1mOjdB0WbvHA== Message-ID: <143cac88-2a97-4f36-bb2e-039f7e0de777@kernel.org> Date: Mon, 15 Jun 2026 20:33:10 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH next-20260615] mm/slab: Fix build error due to extra argument Content-Language: en-US To: Calvin Owens , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Roman Gushchin , David Rientjes , Christoph Lameter , Hao Li , Andrew Morton , Harry Yoo References: <8a5c513e810a216ca221bbec94c96ffbf65da4be.1781540225.git.calvin@wbinvd.org> From: "Vlastimil Babka (SUSE)" Autocrypt: addr=vbabka@kernel.org; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSNWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBrZXJuZWwub3JnPsLBsAQTAQoAWhYhBKlA1DSZLC6OmRA9UCJPp+fM gqZkBQJqFFy6GxSAAAAAAAQADm1hbnUyLDIuNSsxLjEyLDIsMgIbAwUJGtCBUAULCQgHAwUV CgkICwUWAgMBAAIeBQIXgAAKCRAiT6fnzIKmZJIUEADFx/tREzUImHrEwVHeSvDFmA7tJysI UVrlvrM09E7GIuzphzv7jYmo8n3ANpCczLEVr4G0syYQdTigaZgv3+FQDIIzhKih1IHhu1Ei XHlywNWKnQxxQEUNi5Mwx43wQz5XVw9F1A7gtKBKNtfogO511hAbrzagrYajyQacEJ/+sfhZ 9Da8ltHIXD8pcYaHUfQgEusCgmEd9+KrUwrTbckFKmYq5chuE6yJ4J0EmWknL096jIE6CnzF FRslQ3B1UKDjxVsm1ZHfir5NeWszLkTvGFsddFaWTgh8UycESG6VQzKXjjewXu2pG7YQYRpj QKm1W5X2TkwWkXRBZTmfmbhxIUMh3+zf5wQ463rSmDN/8v81tdqBtAW6rH/kzg1GvkaTHXn0 507yEHFzBksk2viAuIxxr7km8+/KARYLIdGtx30EG8cKzAUZOK6WqxtNCsXUJNrVE8CWrCaD icoNu7Fs1c5hmPHdSTnU48ce67449DdnO4neLSNhRiGlMHJgfJUmgrxu/hcYeOZ3haWmEQ2w uW1Mh01OHi8QZHCEyAbABrPs9GUgccc/4eYXX9hIgxfSkYzn8f+8NuIFPWl/0uTvjgqU29FQ SbzOLxHq9439Ox40G5mS5eZXRGxITYR+6TXvRGI6P/264jvflnr/pDGUttaikU+0W+1uxgKH cmYbEc7ATQRbGTU1AQgAn0H6UrFiWcovkh6EXVcl+SeqyO6JHOPm+e9Wu0Vw+VIUvXZVUVVQ La1PQDUi6j00ChlcR66g9/V0sPIcSutacPKfdKYOBvzd4rlhL8rfrdEsQw5ApZxrA8kYZVMh FmBRKAa6wos25moTlMKpCWzTH84+WO5+ziCTsTUZASAToz3RdunTD+vQcHj0GqNTPAHK63sf bAB2I0BslZkXkY1RLb/YhuA6E7JyEd2pilZOrIuBGl/5q2qSakgnAVFWFBR/DO27JuAksYnq +aH8vI0xGvwn75KqSk4UzAkDzWSmO4ZHuahKtQgZNsMYV+PGayRBX9b9zbldzopoLBdqHc4n jQARAQABwsF8BBgBCgAmAhsMFiEEqUDUNJksLo6ZED1QIk+n58yCpmQFAmfIHFQFCRYU6J8A CgkQIk+n58yCpmS2PA//bqN1LfcotmArgElsa+0EGZSQlYgK48pm8WAeTXTngudP9IJ4SuKY HR5RNjHcBeqN+Me0zxRqYzRb8nGanHEkDyf4Im8DQM8d6vbyU+FcPmG4skud4kgS1zMHnlVd SXfSIwKC/hKgdHG8aBV7545Lz9X6Iohea+94wneD0aw/hqF+QWewGZhWJriWAZtvEkzNjQOi 4U9F/trLten/x7bpphDSnDMKJtITbtzATT1Dq7o7VpIUK1nCTQALMuMjKCdi8OdU/+V+R3O4 0PXWvX8qrvqYapVbZ+9KqT74FsuB0Ya9uXwgBF2Q6cRuETZk5vqaqKxzqoQZCO8AOz/58j6O 2RHNy/mZEN+7tJ5Tsq42zVJ4jxsT8b9YplavCMsnBgDeRWhcbYhCyttoL7nYISyWg4kQYZ/P wIV3OuNv2f8iKYsxNsRuClOAF82+gvqOy1/1pprFjy8uo2pkoOrb63aOP3vO5VHnRKgra6dq NcaZ+c6J4H+nEJGi2SkHAUJz5oBzuThvPudLvPA/SK8sKoM01IRxSihev/S/5WLazXB1PGem OCbvzC1IjWJJraxiDJ5IygokapUa2RP7+WBR22skQ3SSl6G107QgWKSyTOGWEaRmV53vxQLV jXuCmzSSasTL60zq5yGrT4/DYQVSNEUiUbG4pYekxJujNeEDkUlky0Y= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/15/26 20:10, Calvin Owens wrote: > On Monday 06/15 at 10:12 -0700, Calvin Owens wrote: >> On Monday 06/15 at 09:32 -0700, Calvin Owens wrote: >> > mm/slub.c:5553:30: error: too many arguments to function call, expected 5, have 6 >> > 5552 | return __do_kmalloc_node(size, NULL, flags, node, >> > | ~~~~~~~~~~~~~~~~~ >> > >> > Fix by removing the nonexistent size argument. >> > >> > Closes: https://lore.kernel.org/all/178153914528.15282.16770125845520023465@330cfa3079ca/ >> > Signed-off-by: Calvin Owens >> > --- >> > I needed to test -next this morning, so passing this along, but please >> > don't go to any extra trouble to use it or credit me if you already >> > fixed it :) >> >> Ugh, nevermind, a different kconfig now fails the opposite way: >> >> mm/slub.c:5551:24: error: too few arguments to function ‘__do_kmalloc_node’; expected 6, have 5 >> 5551 | return __do_kmalloc_node(NULL, flags, node, >> >> > mm/slub.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) > > I guess the line number should have been a clue... I was building on > different machines that fetched at different times, and there were > actually two different SHAs for next-20260615 this morning: > > 700f8f17ac2c > Author: Mark Brown > Date: Mon Jun 15 15:43:39 2026 +0100 (3 hours ago) > Commit: Mark Brown > Date: Mon Jun 15 15:43:39 2026 +0100 (3 hours ago) > Subject: Add linux-next specific files for 20260615 > > 8d6dbbbe3ba6 > Author: Mark Brown > Date: Mon Jun 15 17:26:20 2026 +0100 (2 hours ago) > Commit: Mark Brown > Date: Mon Jun 15 17:26:20 2026 +0100 (2 hours ago) > Subject: Add linux-next specific files for 20260615 > > My patch was for the first one. But the second one has a fix for this > applied, so just drop this patch :) Not a fix, but the newer -next snapshot used older version of the slab tree. The current version was actually fixed a while ago but I forgot to git push :/ Sorry about the trouble. >> > diff --git a/mm/slub.c b/mm/slub.c >> > index b1de95046b0b..7660f7fa0b2c 100644 >> > --- a/mm/slub.c >> > +++ b/mm/slub.c >> > @@ -5549,7 +5549,7 @@ void *__kmalloc_flags_noprof(DECL_TOKEN_PARAMS(size, token), gfp_t flags, >> > }; >> > >> > if (alloc_flags_allow_spinning(alloc_flags)) { >> > - return __do_kmalloc_node(size, NULL, flags, node, >> > + return __do_kmalloc_node(NULL, flags, node, >> > PASS_TOKEN_PARAM(token), &ac); >> > } else { >> > return __kmalloc_nolock_noprof(PASS_TOKEN_PARAMS(size, token), >> > -- >> > 2.53.0 >> >