From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m19731114.qiye.163.com (mail-m19731114.qiye.163.com [220.197.31.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 732CE33FE01 for ; Mon, 12 Jan 2026 08:26:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.114 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768206383; cv=none; b=AhyQuJclkfl/cRlvINRNpowNUHVTtp/g09rFKb2oxJP615RDDVcbnXmMo4l7rDm6hkHo/yzS/OnizxNvHcRz+5D2Psr3aQWy1HgJlJ1aIfUduHdepISAoBIDUXq0aB79kzL749cN/5zoi3TXkJmgnwgTczd11m4aMH5auZlAXyY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768206383; c=relaxed/simple; bh=LcdXfYOaUD/0RTpj6ydSKv4h1l4ulr91oiCKUhAct48=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UHaKaPnVZhWH1YY99oeLZt76paQHMaZI6vjpeEN/29vhKZ7KNeLsj2tTCc8IeYIHInPzh9smVyA/iO+/Xoo3+MZTpPn9ZxVYlR7KCZb0wbipBNgwighFnxl0CmJVHIhVv9xhHsW5KWn15YRhW3MLGHmMFm1Ia6NvGBr+trDj7Kg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=RiTaAr66; arc=none smtp.client-ip=220.197.31.114 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="RiTaAr66" Received: from [172.16.12.163] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 304ebf58b; Mon, 12 Jan 2026 16:26:10 +0800 (GMT+08:00) Message-ID: <143cd9e0-5920-4cce-b544-184aa62373a5@rock-chips.com> Date: Mon, 12 Jan 2026 16:26:07 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] dt-bindings: mfd: Add rk801 binding To: Krzysztof Kozlowski , lee@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20251231030951.818-1-chenjh@rock-chips.com> <20251231030951.818-2-chenjh@rock-chips.com> From: Joseph Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Tid: 0a9bb150079d09d2kunm95938ed44b0845 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQk8fH1YdTUxCH00dHkgeTRhWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSU9PT0 hVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=RiTaAr66ETFxlGayKoGRlJ8opTlkrf89KROqI7PiR5wM4kisJ0OrgGPuNP+3MTfW/tE9+kszmO9nUedz97tBFCejuZc78m7KyGlEb6fkcyQNR3eQHl1X3Y7iPwjSJNwi0PI+31g+P9XEThjQ7Py2KZMDkHhzZgMLYDYImccCe88=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=9BosJ6TqXxeRAhIHFZ+GY3svJkC+gr/506vJlDBIfhs=; h=date:mime-version:subject:message-id:from; 在 2025/12/31 15:33, Krzysztof Kozlowski 写道: > On 31/12/2025 04:09, Joseph Chen wrote: >> Add DT binding document for Rockchip's RK801 PMIC >> >> Signed-off-by: Joseph Chen >> --- > > 1. Please use scripts/get_maintainers.pl to get a list of necessary > people and lists to CC. It might happen, that command when run on an > older kernel, gives you outdated entries. Therefore please be sure you > base your patches on recent Linux kernel. > > Tools like b4 or scripts/get_maintainer.pl provide you proper list of > people, so fix your workflow. Tools might also fail if you work on some > ancient tree (don't, instead use mainline) or work on fork of kernel > (don't, instead use mainline). Just use b4 and everything should be > fine, although remember about `b4 prep --auto-to-cc` if you added new > patches to the patchset. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. Performing review on untested code might be > a waste of time. > > Please kindly resend and include all necessary To/Cc entries. > > > 2. Node names should be generic. See also an explanation and list of > examples (not exhaustive) in DT specification: > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > If you cannot find a name matching your device, please check in kernel > sources for similar cases or you can grow the spec (via pull request to > DT spec repo). > > 3. Underscore is not allowed in node names. Neither capital letters. > Please read DTS coding style. > > Best regards, > Krzysztof > Thanks for the review and advice . I will fix all these problems in v2. -- Best regards, Joseph Chen