From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752231AbbHTLXk (ORCPT ); Thu, 20 Aug 2015 07:23:40 -0400 Received: from lgeamrelo04.lge.com ([156.147.1.127]:43165 "EHLO lgeamrelo04.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751271AbbHTLWl (ORCPT ); Thu, 20 Aug 2015 07:22:41 -0400 X-Original-SENDERIP: 10.177.222.33 X-Original-MAILFROM: byungchul.park@lge.com From: byungchul.park@lge.com To: mingo@kernel.org, peterz@infradead.org Cc: linux-kernel@vger.kernel.org, yuyang.du@intel.com, Byungchul Park Subject: [PATCH v4 2/5] sched: make task_move_group_fair adjust cfs_rq's load in case of queued Date: Thu, 20 Aug 2015 20:21:57 +0900 Message-Id: <1440069720-27038-3-git-send-email-byungchul.park@lge.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1440069720-27038-1-git-send-email-byungchul.park@lge.com> References: <1440069720-27038-1-git-send-email-byungchul.park@lge.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Byungchul Park se's average load should be added to new cfs_rq, not only in case of !queued but also in case of queued. older code managed cfs_rq's blocked load separately. in that case, the blocked load was meaningful only in case that the se is in !queued. but now load tracking code is changed, it is not true. code adjusting cfs_rq's average load should be changed. Signed-off-by: Byungchul Park --- kernel/sched/fair.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index a43023b..9f93c8b 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8041,13 +8041,12 @@ static void task_move_group_fair(struct task_struct *p, int queued) se->vruntime -= cfs_rq_of(se)->min_vruntime; set_task_rq(p, task_cpu(p)); se->depth = se->parent ? se->parent->depth + 1 : 0; - if (!queued) { - cfs_rq = cfs_rq_of(se); + cfs_rq = cfs_rq_of(se); + if (!queued) se->vruntime += cfs_rq->min_vruntime; - /* Virtually synchronize task with its new cfs_rq */ - attach_entity_load_avg(cfs_rq, se); - } + /* Virtually synchronize task with its new cfs_rq */ + attach_entity_load_avg(cfs_rq, se); } void free_fair_sched_group(struct task_group *tg) -- 1.7.9.5