From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752179AbbHTLXj (ORCPT ); Thu, 20 Aug 2015 07:23:39 -0400 Received: from lgeamrelo04.lge.com ([156.147.1.127]:43171 "EHLO lgeamrelo04.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751286AbbHTLWl (ORCPT ); Thu, 20 Aug 2015 07:22:41 -0400 X-Original-SENDERIP: 10.177.222.33 X-Original-MAILFROM: byungchul.park@lge.com From: byungchul.park@lge.com To: mingo@kernel.org, peterz@infradead.org Cc: linux-kernel@vger.kernel.org, yuyang.du@intel.com, Byungchul Park Subject: [PATCH v4 3/5] sched: sync a se with prev cfs_rq when changing cgroup Date: Thu, 20 Aug 2015 20:21:58 +0900 Message-Id: <1440069720-27038-4-git-send-email-byungchul.park@lge.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1440069720-27038-1-git-send-email-byungchul.park@lge.com> References: <1440069720-27038-1-git-send-email-byungchul.park@lge.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Byungchul Park current code is wrong with cfs_rq's average load when changing a task's cfs_rq to another. i tested with "echo pid > cgroup" and found that e.g. cfs_rq->avg.load_avg became larger and larger whenever changing cgroup to another again and again. we have to sync se's average load with both *prev* cfs_rq and next cfs_rq when changing its cgroup. Signed-off-by: Byungchul Park --- kernel/sched/fair.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 9f93c8b..d58e9aa 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8037,8 +8037,12 @@ static void task_move_group_fair(struct task_struct *p, int queued) if (!queued && (!se->sum_exec_runtime || p->state == TASK_WAKING)) queued = 1; + cfs_rq = cfs_rq_of(se); if (!queued) - se->vruntime -= cfs_rq_of(se)->min_vruntime; + se->vruntime -= cfs_rq->min_vruntime; + + /* Synchronize task with its prev cfs_rq */ + detach_entity_load_avg(cfs_rq, se); set_task_rq(p, task_cpu(p)); se->depth = se->parent ? se->parent->depth + 1 : 0; cfs_rq = cfs_rq_of(se); -- 1.7.9.5