From: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
To: <lee.jones@linaro.org>
Cc: <sameo@linux.intel.com>, <patches@opensource.wolfsonmicro.com>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH 3/6] mfd: arizona: Downgrade type mismatch messages to dev_warn
Date: Thu, 20 Aug 2015 12:48:00 +0100 [thread overview]
Message-ID: <1440071283-23589-4-git-send-email-rf@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1440071283-23589-1-git-send-email-rf@opensource.wolfsonmicro.com>
If the declared codec type doesn't match the detected type
we issue a log message but carry on registering the device,
so a dev_warn() is appropriate rather than a dev_err()
Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
---
drivers/mfd/arizona-core.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index 73d26dd..cb09172 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -1132,8 +1132,8 @@ int arizona_dev_init(struct arizona *arizona)
case 0x5102:
type_name = "WM5102";
if (arizona->type != WM5102) {
- dev_err(arizona->dev, "WM5102 registered as %d\n",
- arizona->type);
+ dev_warn(arizona->dev, "WM5102 registered as %d\n",
+ arizona->type);
arizona->type = WM5102;
}
apply_patch = wm5102_patch;
@@ -1151,8 +1151,8 @@ int arizona_dev_init(struct arizona *arizona)
break;
default:
type_name = "WM5110";
- dev_err(arizona->dev, "WM5110 registered as %d\n",
- arizona->type);
+ dev_warn(arizona->dev, "WM5110 registered as %d\n",
+ arizona->type);
arizona->type = WM5110;
break;
}
@@ -1163,8 +1163,8 @@ int arizona_dev_init(struct arizona *arizona)
case 0x8997:
type_name = "WM8997";
if (arizona->type != WM8997) {
- dev_err(arizona->dev, "WM8997 registered as %d\n",
- arizona->type);
+ dev_warn(arizona->dev, "WM8997 registered as %d\n",
+ arizona->type);
arizona->type = WM8997;
}
apply_patch = wm8997_patch;
@@ -1183,8 +1183,8 @@ int arizona_dev_init(struct arizona *arizona)
default:
type_name = "WM8998";
- dev_err(arizona->dev, "WM8998 registered as %d\n",
- arizona->type);
+ dev_warn(arizona->dev, "WM8998 registered as %d\n",
+ arizona->type);
arizona->type = WM8998;
}
--
1.9.1
next prev parent reply other threads:[~2015-08-20 12:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 11:47 [PATCH 0/6] mfd: arizona: Various improvements and refactoring Richard Fitzgerald
2015-08-20 11:47 ` [PATCH 1/6] mfd: arizona: factor out DCVDD isolation control Richard Fitzgerald
2015-08-20 11:47 ` [PATCH 2/6] mfd: arizona: factor out checking of jack detection state Richard Fitzgerald
2015-08-20 11:48 ` Richard Fitzgerald [this message]
2015-08-20 11:48 ` [PATCH 4/6] mfd: arizona: Simplify adding subdevices Richard Fitzgerald
2015-08-20 11:48 ` [PATCH 5/6] mfd: arizona: Remove use of codec build config #ifdefs Richard Fitzgerald
2015-08-20 11:48 ` [PATCH 6/6] mfd: arizona: use correct type ID for device tree config Richard Fitzgerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440071283-23589-4-git-send-email-rf@opensource.wolfsonmicro.com \
--to=rf@opensource.wolfsonmicro.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome