From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753255AbbHUDhS (ORCPT ); Thu, 20 Aug 2015 23:37:18 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:36658 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753191AbbHUDhP (ORCPT ); Thu, 20 Aug 2015 23:37:15 -0400 From: yalin wang To: adaplas@gmail.com, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: yalin wang Subject: [RFC V2] fbdev/nvidia:change reverse_order() macro Date: Fri, 21 Aug 2015 11:36:59 +0800 Message-Id: <1440128219-2951-1-git-send-email-yalin.wang2010@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This change reverse_order() to swab32(bitrev32()), so that it can have better performance on some platforms. Signed-off-by: yalin wang --- drivers/video/fbdev/nvidia/nv_local.h | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/video/fbdev/nvidia/nv_local.h b/drivers/video/fbdev/nvidia/nv_local.h index 68e508d..2c6baa1 100644 --- a/drivers/video/fbdev/nvidia/nv_local.h +++ b/drivers/video/fbdev/nvidia/nv_local.h @@ -97,18 +97,19 @@ #ifdef __LITTLE_ENDIAN +#include #include +static inline void reverse_order(u32 *data) +{ + *data = swab32(bitrev32(*data)); +} -#define reverse_order(l) \ -do { \ - u8 *a = (u8 *)(l); \ - a[0] = bitrev8(a[0]); \ - a[1] = bitrev8(a[1]); \ - a[2] = bitrev8(a[2]); \ - a[3] = bitrev8(a[3]); \ -} while(0) #else -#define reverse_order(l) do { } while(0) -#endif /* __LITTLE_ENDIAN */ +static inline void reverse_order(u32 *data) +{ + +} + +#endif /* __LITTLE_ENDIAN */ #endif /* __NV_LOCAL_H__ */ -- 1.9.1