From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932312AbbHXCU6 (ORCPT ); Sun, 23 Aug 2015 22:20:58 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:33885 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932259AbbHXCUa (ORCPT ); Sun, 23 Aug 2015 22:20:30 -0400 From: Joonsoo Kim X-Google-Original-From: Joonsoo Kim To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Mel Gorman , Rik van Riel , David Rientjes , Minchan Kim , Joonsoo Kim Subject: [PATCH v2 8/9] mm/compaction: don't use higher order freepage than compaction aims at Date: Mon, 24 Aug 2015 11:19:32 +0900 Message-Id: <1440382773-16070-9-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1440382773-16070-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1440382773-16070-1-git-send-email-iamjoonsoo.kim@lge.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Purpose of compaction is to make high order page. To achive this purpose, it is the best strategy that compaction migrates contiguous used pages to fragmented unused freepages. Currently, freepage scanner don't distinguish whether freepage is fragmented or not and blindly use any freepage for migration target regardless of freepage's order. Using higher order freepage than compaction aims at is not good because what we do here is breaking high order freepage at somewhere and migrating used pages from elsewhere to this broken high order freepages in order to make new high order freepage. That is just position change of high order freepage. This is useless effort and doesn't help to make more high order freepages because we can't be sure that migrating used pages makes high order freepage. So, this patch makes freepage scanner only uses the ordered freepage lower than compaction order. Signed-off-by: Joonsoo Kim --- mm/compaction.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/mm/compaction.c b/mm/compaction.c index ca4d6d1..e61ee77 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -455,6 +455,7 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, unsigned long flags = 0; bool locked = false; unsigned long blockpfn = *start_pfn; + unsigned long freepage_order; cursor = pfn_to_page(blockpfn); @@ -482,6 +483,20 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, if (!PageBuddy(page)) goto isolate_fail; + if (!strict && cc->order != -1) { + freepage_order = page_order_unsafe(page); + + if (freepage_order > 0 && freepage_order < MAX_ORDER) { + /* + * Do not use high order freepage for migration + * taret. It would not be beneficial for + * compaction success rate. + */ + if (freepage_order >= cc->order) + goto isolate_fail; + } + } + /* * If we already hold the lock, we can skip some rechecking. * Note that if we hold the lock now, checked_pageblock was -- 1.9.1